The 2026 Drupal Business Survey is open. Your response will help shape the future of the Drupal business ecosystem.(First off, excellent module. Seems to be doing a great job so far!)
On first installation, I found my field displayed alone inside a fieldset, below the standard form_element label. I can't understand why this would be necessary, and it doesn't match the field presentation convention (as I understand it).
The attached patch removes the fieldset.
| Comment | File | Size | Author |
|---|---|---|---|
| npn-fieldset.patch | 640 bytes | ezheidtmann |
Comments
Comment #1
NealB-1 commentedI'm glad you like the module!
The fieldset is superfluous as things stand. I used the design of the "Phone Number" module as a starting point, and that module has a country code select box, a phone number textfield, and an optional extension textfield making up the widget. With all three form elements, it looked better inside a fieldset. My intent is to bring back the extension textfield, at least. The country code select complicates the design significantly, and I suspect that the vast majority of websites don't need truly international phone number support. I had it partially implemented, but I decided to go back to basics and just get the module released, rather than spend a lot of time on something that hardly anyone may need.
The design is very much still in flux. My next priority is to create an interface to administer the patterns. As for the input controls, I was hoping to get feedback from users as to what is most important. Another question mark is how important is compatibility with the other phone number modules? Is there lots of data out there in ckng's Phone Number field that people want to use with a different widget and formatter?
My philosophy is to create the phone number module people actually need and want. If only 1% of potential users need true international numbers, then I will prioritize that last. The same goes for extension support and compatibility with other phone number modules. My intuitive sense is that, generally speaking, people's needs are very basic.
Thanks for your feedback and for being an extremely early adopter. There are plenty of updates on the way.
Comment #2
ezheidtmann commentedThanks for sharing your thoughts! In my use case, the single 10-digit field is just what I need. The JS adding () and - is awesome.
In my opinion, compatibility is not a big concern. The phone module I was using in D6 was clunky and difficult to use, so don't let it constraint your development. If someone wants to import a bunch of numbers (might be me in a few months!), they can write an upgrade path.
Back to the issue at hand, even if there were more subfields, I don't believe a fieldset is necessary -- put all the fields on one line and call it good. IMO, fieldsets are for bigger things.
P.S. I may have more fixes & adjustments. Are you interested?
Comment #3
NealB-1 commented"The phone module I was using in D6 was clunky and difficult to use"
-- I presume that you were using one of the two modules on drupal.org
"I don't believe a fieldset is necessary -- put all the fields on one line and call it good. IMO, fieldsets are for bigger things."
-- Thanks for that insight.
"I may have more fixes & adjustments. Are you interested?"
-- Yes, absolutely!
Comment #4
NealB-1 commentedComment #5
NealB-1 commentedI commented out the fieldset and committed the change. I don't want to get rid of the code for good, but it's now disabled.