node's input format settings not being reported by blogapi [#12984]

There is a problem with CVS blogapi, and how blog API clients know what input filter is used for each post. Currently, no information is sent -- the field is blank. Here is an email from the MarsEdit author regarding the problem:

When getting recent posts, the value for the text filter field for each post is always an empty string. For historical reasons, the text filter field name is mt_convert_breaks -- and it's always an empty string in the XML-RPC response, like this:

<member><name>mt_convert_breaks</name>
<value><string></string></value>

It should instead contain the identifier of the text filter. For instance, on your site, the Markdown With SmartyPants filter has an identifier of 1. So for a post that uses that filter, the XML should look like this:

<member><name>mt_convert_breaks</name>
<value><string>1</string></value>

Comment	File	Size	Author
#11	blogapi_query.patch	1.79 KB	Zen
#11
#6	blogapi_node_settings.patch_0.txt	1.95 KB	Heine
#5	blogapi_node_settings.patch.txt	1.94 KB	Heine
#4	12984_blogapi.patch	1.2 KB	snej
#4

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

walkah CreditAttribution: walkah commented 17 January 2005 at 17:02

Assigned:

Unassigned

» walkah

Comment #2

Uwe Hermann CreditAttribution: Uwe Hermann commented 22 August 2005 at 13:38

walkah, are you still working on this? Any progress?

Comment #3

snej CreditAttribution: snej commented 27 December 2005 at 17:51

Status:

Active

» Needs work

I independently discovered this problem last night (with Ecto), tracked down the cause, and fixed it.

In blogapi.module, the function blogapi_blogger_get_recent_posts() runs a custom SELECT query to get the nodes. Unfortunately it's missing the 'format' and 'comment' columns, so when the rows get passed to _blogapi_get_post(), it generates empty strings for the XML-RPC 'mt_convert_breaks' and 'mt_allow-comments' attributes.

The fix is simply to amend the query string to add the missing columns. Here's a patch for Drupal 4.6.5's blogapi.module:

321c321
<   $result = db_query_range('SELECT n.nid, n.title,'. ($bodies ? ' n.body,' : '') ." n.created, u.name FROM {node} n, {users} u WHERE n.uid=u.uid AND n.type = '%s' AND n.uid = %d ORDER BY n.created DESC", $type, $user->uid, 0, $number_of_posts);
---
>   $result = db_query_range('SELECT n.nid, n.title,'. ($bodies ? ' n.body, n.format, n.comment,' : '') ." n.created, u.name FROM {node} n, {users} u WHERE n.uid=u.uid AND n.type = '%s' AND n.uid = %d ORDER BY n.created DESC", $type, $user->uid, 0, $number_of_posts);

I haven't contributed to Drupal before so I'm not totally clear on the process for submitting fixes/patches yet. I'll save this, then go read up on the procedures -- looks like I'll need to check out CVS and submit a patch against that. In the meantime I'll set the status to "patch (code needs work)" even though it's the patch, not the code, that needs the work :-)

Comment #4

snej CreditAttribution: snej commented 27 December 2005 at 18:14

Status:

Needs work

» Needs review

File	Size
12984_blogapi.patch	1.2 KB

OK, here [attached] is a patch against top-of-tree CVS. I haven't run the CVS version yet, so this definitely needs to be tested. However, it's just a one-line change to add two columns to a SQL query. I did notice that the 'format' column has been moved from the node table to node_revisions, so I changed my 'n.format' to 'r.format'.