Closed (fixed)
Project:
Ubercart
Version:
7.x-3.x-dev
Component:
Roles
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
4 Oct 2011 at 02:17 UTC
Updated:
27 Oct 2011 at 21:40 UTC
Jump to comment: Most recent file
This bug report pertains to these pages:
admin/store/settings/products(on the Role Assignment tab)node/12345/edit/features/role/23456
I think the information could be more clearly communicated with a few label changes.
A "period" is a certain amount of time (duration), while an "expiration" is a moment in time (instantaneous event). That makes the phrase "Expiration period" difficult for me to get my brain around.
Also, for absolute expirations, we ask for only a date, and we don't specify if we mean the role will expire when that day arrives, or when that day ends.
Here's how I'd fix all of these things:
| Before | After |
|---|---|
| "Expiration period" | "Role expiration" |
| "Default expiration" | "Default role duration (for relative expirations)" |
| "[blank label]" | "Default role expiry date (for absolute expirations)" |
| "When this expiration period will end" | "Expire the role at the beginning of this day" |
| "Override the default ending expiration" | "Override the default role expiration" |
| Comment | File | Size | Author |
|---|---|---|---|
| #1 | uc_roles-clarify_wording-1298614-1.patch | 3.87 KB | dan3h |
Comments
Comment #1
dan3h commentedI went ahead and made these changes, and then tweaked them some more and changed a few of other related bits of text.
I think it's now more clear, concise, and consistent (between the form where you set the defaults and the form that applies to individual products).
Comment #2
dan3h commentedComment #3
longwaveThe patch didn't apply to -dev as some parts of the code had changed recently to include JavaScript states, but I updated and committed most of it: http://drupalcode.org/project/ubercart.git/commitdiff/96dce53
I am still not quite happy with the "absolute role ending" wording, if you have any suggestions to improve this let us know!
Comment #4
longwaveHow about:
Relative from activation time => Relative to purchase date
Absolute role ending => Fixed date
Comment #5
longwaveComment #6
dan3h commented(I'm just looking at the patch you committed, and I'm not sure if all the phrases that I'm talking about here, below, are in it... so apologies in advance if this post is slightly confusing due to my referring to the wrong phrases. I think you'll still see what I'm trying to say.)
Yes, I like those two wordings. "Relative to purchase date" and "Fixed date" sound ok. I think it's important that the following two inputs should match them, too. i.e. The ones which I had labelled "(for relative expirations)" and "(for absolute expirations)".
If you're up to changing a bit more than just labels, ideally, the absolute/relative choice should not be a dropdown menu, but rather a pair of radio buttons, and those radio buttons should be each in front of the corresponding input. That is, the "relative" radio button is just to the left of the "(for relative expirations)" inputs (where you choose the number of years or months), and the "absolute" radio button would be just to the left of the place where you specify the date you want it to expire on. That would make it really intuitive and self-explanatory. And actually, then the labels on the radio buttons and the corresponding inputs would be quite redundant (eg. "Relative to purchase date" which is right next to "(for relative expirations)", and you could merge them, making for even less text, even easier for the user to figure out what to do.
Comment #7
longwaveI think it's quite intuitive already, actually; if you try it out you will see that the relevant period or date fields appear/disappear depending on what you select in the dropdown. This is why I didn't add the bracketed text.
I agree with changing the dropdown to radios as well, will look at that soon.
Comment #8
longwaveCommitted the suggested text changes.
If we switch to radio buttons, it's actually quite complicated to insert fields at the end of each radio button option as far as I can see. With the relevant fields appearing when appropriate, I think it's currently more intuitive to use the dropdown.
Comment #9
dan3h commentedSounds good to me. The appearing/disappearing part was not working for me, and if it was, I don't think the radio-buttons idea would have even occurred to me. That sounds like a very intuitive, pretty much ideal setup the way you have it now, if it is only showing the relevant fields.
(And I'm not sure why the appearing/disappearing wasn't working for me, but I'm not going to worry about it. I don't have the latest dev code, and the module is functioning happily for me as-is.)
Thanks!
Comment #10
longwaveI think this is fixed, then. Thanks for your input on this!