I'm using the Automodal module, and when linking to other nodes from an modal frame, it's opening the content into a new window/tab instead of the parent window/tab. I think it's related to this issue #1166990: target="_new" incorrectly added to javascript actions, as I made a change to line 112 changing the target from "_new" to "_top" as a test, and the modal links behave as I expected.
Am I using the two modules incorrectly or is this a bug?
| Comment | File | Size | Author |
|---|---|---|---|
| #4 | prevent-new-window-when-linking-from-modal-1298736-4.patch | 1.12 KB | thedavidmeister |
| #2 | 1298736-2.patch | 363 bytes | lelizondo |
| #1 | prevent-new-window-when-linking-from-modal-1298736-1.patch | 363 bytes | thedavidmeister |
Comments
Comment #1
thedavidmeister commentedthanks, this was causing problems for me in two ways.
I'm trying to display a signup form inside a modal frame and
1. I'm using legal, which has a link to the site's T&C that i don't want to open in a new tab
2. I'm using the chozen javascript library to style my dropdown menus and the markup contains links that completely break without this fix.
patch attached is rolled against dev version of modal frame for D6.
Is there some reason that links are opened in a new tab? it seems to me to be one of those behaviours that people instinctively assume "should" happen without any other great reason, so there should be no harm in overriding it, but of course I don't actually know in this case.
Comment #2
lelizondo commentedpatch didn't work for me although the solution did. I'm attaching a new patch with the same solutionEdit: both patches are identical. I wasn't applying the patch correctly.
Comment #3
thedavidmeister commented:P
Comment #4
thedavidmeister commentedso now I need legal to open in a new tab, but I still don't want my themed dropdowns to break.
This patch addresses my concern with the javascript library I was using by not parsing links that contain "javascript" as the href in this case is "javascript:void();"
Also, I'm using _blank instead of _new as _blank is actually in the HTML spec whereas _new is not.
Comment #5
dsnopekPatch in #4 looks good, thanks! Committed in 1650917.