Posted by jamiecuthill on October 4, 2011 at 10:03am
6 followers
| Project: | Fusion |
| Version: | 7.x-1.x-dev |
| Component: | Code |
| Category: | bug report |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | needs review |
Issue Summary
When Fusion is calculating grid widths on regions, it loads the blocks in each region from core block placement and blocks placed with the context module.
The context module has a region reaction which disables a region by removing blocks from the page array. Since Fusion counts the blocks by directly accessing them from core and context the region disable reaction doesn't notify Fusion that it is disabled. A solution for this is to alter the fusion_core_block_list() function to also check the region reaction.
I have included a patch needs testing.
| Attachment | Size | Status | Test result | Operations |
|---|---|---|---|---|
| fusion_block_list_region_reaction.patch | 875 bytes | Idle | PASSED: [[SimpleTest]]: [MySQL] 0 pass(es). | View details | Re-test |
Comments
#1
Actually, here is a patch for the current state of 1.x-dev
#2
#3
Thanks for the patch. The patch from comment #1 worked for me.
#4
The last submitted patch, fusion_block_list_region_reaction-1298916-1.patch, failed testing.
#5
#6
Hi, had time. Patch attached.
#7
The last submitted patch, context-region-disabled-reaction-1298916-6.patch, failed testing.
#8
Hm, weird.
#9
The last submitted patch, context-region-disabled-reaction-1298916-7.patch, failed testing.
#10
One last try. I have no idea which branch the bot is patching the file.. :(
#11
My bad, didn't notice 'region' in
context_get_plugin('reaction', 'region').