Media browser should resize its iFrame when content is updated

Out of curiosity: what happens if the required height out-grows the window-size? (I haven't actually tested the patch yet)

The code looks good and is working well on my tests (changing the exposed filter of the "view library" tab). The patch had a little whitespace error, so here is a simple reroll.

Patch looks good and works as advertised.

I have a problem even with the above patch in that the resizeIframe call occurs before the images have finished loading. As the images load the iframe also needs to expand. I firstly experimented with a simple interval function that is started (and stopped) with the media browser popup. It worked, however it's not an ideal situation to be checking the iframe height every second when nothing is really happening.

Here are the code snippets I tried in media.popups.js for that though I have a better solution.

Drupal.media.popups.mediaBrowser.mediaBrowserOnLoad = function (e) {
  var options = e.data;
  Drupal.media.popups.watcher = setInterval(function() {
    if (window.frames["mediaBrowser"]) {
      //window.frames["mediaBrowser"].Drupal.media.browser.resizeIframe();
    }
  }, 1000);
...

Drupal.media.popups.mediaBrowser.finalizeSelection = function () {
  clearInterval(Drupal.media.popups.watcher);
...

Now the better solution is to attach a load event handler on each image within the library view results that will resize the iframe. Patch attached.

That might not apply cleanly. Here is a fixed version.

Nice catch. I would choose the setInterval option. It's the most reliable method and it will not have much impact on performance.
according to http://api.jquery.com/load-event/

Caveats of the load event when used with images
...

• It doesn't work consistently nor reliably cross-browser
• It doesn't fire correctly in WebKit if the image src is set to the same src as before
• It doesn't correctly bubble up the DOM tree
• Can cease to fire for images that already live in the browser's cache

I didn't realise the load event had those issues. Shall I create a patch for the interval implementation?

Here is the patch for the interval implementation. It's set to resize every second so you will noticed a little lag in the resizing.

The patch in #12 looks good and and is working well. A little problem is that I was not able to reproduce the issue, even without the patch. So either it has have been fixed somewhere else or I did something wrong.

#8: resize_media_browser-1298962-7.patch queued for re-testing.

#12: resize_media_browser-1298962-8.patch queued for re-testing.

fixed to work with latest release (unstable5)

per #20

I've manually applied the changes as proposed in the patch at # to unstable7-dev.
It works, but I have to agree with #15, that it is a too costly operation.
And browsing images is from an UX point of view not so smooth, since there is a one second lag.

In my patch I set the interval much lower as to get a more smooth transition while the images load.
The interval only starts at the browser tab and stops after all images are loaded.
Also, the resize is only triggered when the body height is taller than the iframe.

The caveats of load() mentioned in #9, are in my implementation imho not that relevant since if load isn't triggered resizing still works and only the interval keeps on running (checking heights).

Patch against unstable7.

patch introduces tabs instead of two spaces per drupal codings standards

This doesn't fix the issue for me. I can't see any improvement.

typo

This should be fixed in the latest -dev as part of #1972628: Browser size doesn't fit it's content.