Download & Extend
Issues

Secondary tabs order reversed in LTR

Posted by beltofte on October 4, 2011 at 12:37pm
Project:Drupal core
Version:7.x-dev
Component:Seven theme
Category:bug report
Priority:normal
Assigned:Unassigned
Status:closed (fixed)
Issue tags:needs backport to D7

Issue Summary

Was fighting with the order of secondary tabs made created from Panels and figured out that the Seven theme in Drupal 7 is showing them reversed. They are displayed correct in other themes like Bartik and Rubik. They are displayed fine in RTL though.

Checked the CSS in Firebug and it looks like the "float: right" on "ul.secondary li" is causing the problem.

ul.secondary {
  float: right; /* LTR */
  font-size: 0.923em;
  padding: 0 3px 5px;
  line-height: 1.385em;
  overflow: hidden;
  background-color: #fff;
}
ul.secondary li {
  margin: 0 5px;
  float: right; /* LTR */
}

It's working fine in both LTR and RTL when "float: right" is removed or set to none. Not sure which one is the correct CSS approach.

Attached a D8 patch setting float to none.

AttachmentSizeStatusTest resultOperations
secondary-tabs-float.patch328 bytesIdlePASSED: [[SimpleTest]]: [MySQL] 33,302 pass(es).View details
Login or register to post comments

Comments

#1

Posted by ParisLiakos on October 9, 2011 at 5:56pm

Subscribing!
I thought at first it was menus system bug,but after switching to bartik and other themes menu order was fine!

#2

Posted by ParisLiakos on October 9, 2011 at 5:57pm
Status:active» needs review

#3

Posted by ParisLiakos on October 9, 2011 at 6:35pm
Status:needs review» reviewed & tested by the community

i tried the patch and works.Testbot is also happy:)

#4

Posted by beltofte on October 9, 2011 at 9:24pm

Attached patch for Drupal 7.

AttachmentSizeStatusTest resultOperations
secondary-tabs-float-7.patch328 bytesIdlePASSED: [[SimpleTest]]: [MySQL] 36,608 pass(es).View details

#5

Posted by beltofte on October 9, 2011 at 9:27pm

Hmm..... okay, looks like I should wait attaching a patch for Drupal 7 till the issue is changed to version 7. Testbot might not like the D7 patch on D8.

#6

Posted by Dries on October 10, 2011 at 12:49am
Version:8.x-dev» 7.x-dev

Committed to 8.x. Moving to 7.x for webchick.

#7

Posted by beltofte on October 10, 2011 at 7:42am

#4: secondary-tabs-float-7.patch queued for re-testing.

#8

Posted by webchick on October 17, 2011 at 3:30pm
Status:reviewed & tested by the community» fixed

Committed and pushed to 7.x. Thanks!

#9

Posted by System Message on October 31, 2011 at 3:40pm
Status:fixed» closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.