Use of this module to remove unwanted menu items?

You're right, I forgot to clear the cache. Now the situation is the following;

- my custom access check function is called
- no need to use node_load, the node object is already fully populated
- access to node is denied depending on field_public value, no need to use hook_node_access anymore

But sadly, the corresponding menu item is still displayed, giving the user an "access denied" page.

Any way to remove menu items the user has'nt access to?

At the moment, this module implements just an alternative to hook_node_access, giving some more possibilities as it's not restricted to node paths.

I've just had a quick glance at the forum_access module. Maybe the removal of corresponding menu items does work there because the module is implementing node grants?

Well, this is surely a core issue: there should be a possibility to automatically remove menu items and links to paths the user hasn't access to. As far as I've seen, this ONLY works using the (role-based) permission system, or implementing the node grant system.

Think I'll setup a clean minimal D7 install to do some tests regarding this problem, using node paths and none-node paths, menu items and standard links, and implementing different ways to block access. If you're interested, I'll post the results in some days.

Thanks so far,
Boris

P.S. I've changed the issue title. Better?

In the OP you wrote node access wasn't working (which I agree with), and now you write it's working? I'm confused.

- It doesn't work using hook_node_access() (corresponding menu items are not removed)
- It works by implementing hook_node_access_records / hook_node_grants (corresponding menu items are removed)

I agree it can't work with non-menu links, because the generating function (e.g. l() or the book module) would have to check accessibilty, that's not a menu problem. So let's concentrate on real menu items.

I'll do a test setup and post some screenshots!

I did some further investigations now, and I think the described problem is a core issue, not your module's fault. I've set up a site with ten example nodes, all with menu links, and restricted access to half of them using hook_node_access. This works fine, but the corresponding menu items still show up, despite of the value in menu item's 'access'. Have a look at the attached screenshot.

Using the chain_menu_access module, it's possible to change menu access further on, but items aren't removed, too. Look at the following example code:

<?php
/**
 * Implements hook_init().
 */
function d7a_init() {
  dpm(menu_get_item());
}

/**
 * Implements hook_node_access().
 */
function d7a_node_access($node, $op, $account) {
  if ($account->uid > 0)
    return NODE_ACCESS_IGNORE;
  if ($op != 'view')
    return NODE_ACCESS_IGNORE;
  if ($node->nid % 2)
    return NODE_ACCESS_IGNORE;
  return NODE_ACCESS_DENY;
}

/**
 * Implements hook_menu_alter().
 */

function d7a_menu_alter (&$items) {
  chain_menu_access_chain($items['node/%node'], 'd7a_access_check', array(1));
}

function d7a_access_check ($node) {
  return FALSE;
}

Access is now denied for ALL items, but the menu items aren't removed. So I think this module just does what it's been designed for, namely chaining menu access functions. And this works fine.

Guess I have to find another way to remove inaccessable menu items, maybe by filing a core issue.

Thx for your patience!

Here's a quick workaround for this problem: it's possible to remove menu items the user hasn't access to using a little theme function in template.php:

function mytheme_menu_link(array $variables) {
  $path = $variables['element']['#href'];
  $item = menu_get_item($path);
  if ($item['access'] == TRUE)
    return theme_menu_link ($variables);
}

This has nothing to do with chain menu access api, just for interest. I've made this a core issue: http://drupal.org/node/1277596