What a great module, thanks for sharing it.

One improvement would be:
- Define default titles/tags/metadata on the first page, or use the image name (eg IMG_1775 if the image is named IMG_1775.JPG)
- After uploading, have the option to change the title and metadata of each photo (like uploading multiple images in Facebook)

Currently, all images get the title of the first image (IMG_1775 if that's the first one). This seems a bug to me, but I cannot find it in the code.

Comments

pyrollo’s picture

pyrollo commented
Category: feature » bug

I've just fixed the "title are all the same" issue in the last version.

In the configuration page, you can "edit" one on the settings to tell which fields you want to see on "upload form" and on "edit form".

The module was supposed to show fields according to that configuration. It seems that there is a bug, I got the same behavior (fields not shown).

BarisW’s picture

BarisW commented

Cool, thanks. Will test!

For now; I get a notice.

Notice: Undefined index: settings in upload_nodes_admin_edit_form() (line 102 of upload_nodes.admin.inc).

BarisW’s picture

BarisW commented

Tested, but doesn't seem to work. If I change:

      // Set a title if none
      if (!$node->title) 
 		    $node->title = _upload_nodes_filter_name($uploaded_file['name']);

in upload_nodes_upload_form_submit() to

      // Set a title
      $node->title = _upload_nodes_filter_name($uploaded_file['name']);

it works ;)

BarisW’s picture

BarisW commented
Status: Active » Needs work
pyrollo’s picture

pyrollo commented

It would be a problem to remove the test on node title. In case of a node title entered on the upload form, this title will be ignored.

I've tested on current version, including your patch from #1301288: Several minor improvements and bug fixes and everything seems ok about the title.

BarisW’s picture

BarisW commented
Status: Needs work » Fixed

Yes, indeed. It seems to work now with my patch :) Thanks!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.