According to the Drupal.org 3rd party libraries policy [1] external source code should not be committed with contrib modules, regardless of its license.

This applies to all branches (6,7,8.x) of course.

[1] http://drupal.org/node/422996

Comments

jzacsh’s picture

jzacsh commented

I'm thinking we can simply link to jQuery's CDN as a default solution here, then allow a variable_set to decide if we should be looking for qunit.js/qunit.css in a local/expected path (I'm not quite familiar with D7's new libraries api, but I doubt this applies to D7).

I will play with this approach in the D6 branch (maybe tonight).

jzacsh’s picture

jzacsh commented
Title: remove qunit project's code from this module's codebase » remove qunit project's code from QUnit's codebase

6.x branch is taken care of. Just released beta3 of the 6.x branch to address this issue with an admin/settings form and remove QUnit from 6.x branch of our repo.

ericduran’s picture

ericduran commented

Thats a loosely rule. I think for 8.x it should stay in. Especially if we're going to try to get this into core.

jzacsh’s picture

jzacsh commented
Version: 8.x-1.x-dev » 6.x-1.x-dev
Status: Active » Closed (fixed)

Good point, I'll close this ticket and leave my work in for this in the D6 branch. Thanks for the input.

jzacsh’s picture

jzacsh commented
Issue summary: View changes

Updated issue with link to actual d.o policy.