Closed (fixed)
Project:
Follow
Version:
7.x-2.x-dev
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
5 Oct 2011 at 17:17 UTC
Updated:
14 May 2013 at 15:50 UTC
Jump to comment: Most recent file
The url field in the follow_links db table is varchar(255), but the edit form allows formapi to set its default maxlength of 128.
I've just had a requirement to use a URL which was > 128 chars in length, and couldn't as a result of this formapi default.
Patch attached to explicitly set the #maxlength to match the db table schema.
There are other fields in the form where the situation is the same, but I would have have thought that URL is the most likely to cause users problems.
| Comment | File | Size | Author |
|---|---|---|---|
| #2 | follow.module.patch | 350 bytes | stoob |
| follow_textfield_maxlength_for_network_urls.patch | 536 bytes | mcdruid |
Comments
Comment #1
Chris CharltonAgreed. The patch may be slightly old but I was able to get it to apply.
Comment #2
stoob commentedThis patch is for the D7 version.
It makes since since the dB field is already 255, that input field should be 255. This way we can use longer links and functionality like this: https://dev.twitter.com/docs/tweet-button
Comment #3
q0rban commentedThanks! Committed to 7.x-2.x, 7.x-1.x and 6.x-1.x:
http://drupalcode.org/project/follow.git/commit/801d7a6
http://drupalcode.org/project/follow.git/commit/ac3b3c6
http://drupalcode.org/project/follow.git/commit/604fe23
Comment #4.0
(not verified) commentedspelling