Closed (fixed)
Project:
Domain
Version:
7.x-3.x-dev
Component:
Code
Priority:
Normal
Category:
Feature request
Assigned:
Unassigned
Reporter:
Created:
5 Oct 2011 at 18:23 UTC
Updated:
19 Oct 2011 at 20:00 UTC
Jump to comment: Most recent file
Comments
Comment #1
agentrickardAnd the patch.
Comment #2
dave reidShould [node:domains] be plural? I guess if domain.module itself support multiple domains per node, and it's domain_source that assigns a 'source' domain. Maybe this token should be [node:domain-source:*]?
Also, the current code would not output anything if the token [node:domains] would be used.
Comment #3
agentrickardFixes.
Comment #4
dave reidThe above could will generate all tokens no matter if the user actually provided them or not - something that the new Token API in D7 helps avoid now. To generate the tokens on-demand, we should use the following code instead:
I checked that the domain_get_node_match() is statically cached so calling it more than once is completely fine.
Comment #5
agentrickardLike so?
I put the domain killswitch up higher in the stack. Likely that domain_get_node_match() has already been invoked before we get here.
Comment #6
agentrickardLet's not loop-de-loop, shall we?
Comment #7
dave reid#6 seems good for now - would just be good to add some tests on it but it shouldn't hold this up.
Comment #8
agentrickardCommitting to 7.x.3.