Wrong dependency on module views_bonus

sanduhrs - March 22, 2007 - 12:04
Project:Wiki installation profile
Version:5.x-1.x-dev
Component:Code
Category:bug report
Priority:normal
Assigned:Unassigned
Status:patch (code needs review)
Description

As views_bonus is actually not a .module file, it's not possible to add a dependence on it.
Instead one should add dependencies on the available files.

As I'm not shure which of the views_bonus modules are really needed, the attached patch adds dependencies on all three views_bonus modules which do not depend on other modules to be installed.

Patch attached.
vg

AttachmentSize
drupal_wiki.profile-diff-2007-03-22-12-48-06.patch627 bytes

#1

sanduhrs - March 23, 2007 - 12:49
Title:Wrong dependency in module views_bonus» Wrong dependency on module views_bonus

Just saw, that one of the defined views uses $view->page_type = 'bonus_grid';, which needs views_bonus_grid.module, which depends on panels.module.

Patch updated.
vg

AttachmentSize
drupal_wiki.profile-diff-2007-03-23-13-48-19.patch679 bytes

#2

rötzi - April 5, 2007 - 01:13

It depends on the 'views_bonus' version you use. If you use the 5.x-1.0 version the wiki profile works, with the dev version of views_bonus you need the changes.

I will add both versions, so if you have want to use the dev version you will need to uncomment a line in the installation profile.

Thanks for the report and patch.

 
 

Drupal is a registered trademark of Dries Buytaert.