Performance improvement

The module works as expected, but the solution used could be improved:

Currently Core's system module defines a form element type password_confirm which has two FAPI process functions itself:

$types['password_confirm'] = array(
    '#input' => TRUE,
    '#process' => array('form_process_password_confirm', 'user_form_process_password_confirm'),
    '#theme_wrappers' => array('form_element'),
  );

system.module - function system_element_info

• form_process_password_confirm - adds two inputs: password and the confirmation and the validation function
• user_form_process_password_confirm - adds the JS validation

If we disable user_form_process_password_confirm function using hook_element_info_alter using a better undestanding of Form API we can avoid:

• execution of a process function that just adds JS that later is going to be overwritten
• execution of hook_form_FORM_ID_alter
• an HTTP request asking for user.js that is going to provide code that later will be overwritten
• additional JS code that overwrites the function to check password strength

Here is the patch that changes completely the behaviour of this module and improves performance.