Just noticed this in http://drupalcode.org/project/flickrrippr.git/blob/refs/heads/6.x-6.x:/f...

Introduced @ http://drupalcode.org/project/flickrrippr.git/commitdiff/e6ac230edbe8dbc...

Noticed by way of #1300754: Table {flickrcomments} not created successfully (mysql) - something caught my eye, took me a second look to spot.

Comments

xurizaemon’s picture

xurizaemon
he/him
Location Ōtepoti, Aotearoa 🏝
commented

Uh. Probably won't hurt if I point out the actual bug.

Will this still just get parsed as array('s', /* rest of array is ok */) anyway? Or did PHP stop that awful?

   $schema['flickrsets'] = array(
     'fields' => array(s                                        /* ← s */
       'nid' => array('type' => 'int'),
       'flickrid' => array('type' => 'text'),
     ),
     'primary key' => array('nid'),
   );