Currently the taxonomy permissions are named "delete terms in $vocabulary->vid" and "edit terms in $vocabulary->vid". Is there a reason that the $vocabulary->vid is used instead of $vocabulary->machine_name?

CommentFileSizeAuthor
#3 drupal-n1300962-2-d7.patch1.85 KBdamienmckenna
#3 drupal-n1300962-2-d8.patch1.85 KBdamienmckenna
#1 drupal-n1300962-1-d7.patch1.82 KBdamienmckenna
#1 drupal-n1300962-1-d8.patch1.82 KBdamienmckenna

Comments

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Active » Needs work
StatusFileSize
new drupal-n1300962-1-d8.patch1.82 KB
new drupal-n1300962-1-d7.patch1.82 KB

Here are patches for D7 and D8 to replace the two permissions use of $vocabulary->vid with $vocabulary->name. They need hook_update_N() implementations to update existing permissions, though.

janusman’s picture

janusman commented

I might be wrong but...

Won't permissions be lost if someone decides to rename a vocabulary?

IIUC $vocabulary->name is a user-facing label, not a UUID =) Permissions should have unique IDs of the things they.. uh... allow.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Title: Change taxonomy permissions to use vocabulary name rather than vid » Change taxonomy permissions to use $vocabulary->machine_name rather than vid
StatusFileSize
new drupal-n1300962-2-d8.patch1.85 KB
new drupal-n1300962-2-d7.patch1.85 KB

Corrected the patches to use $vocabulary->machine_name, not $vocabulary->name.

xjm’s picture

xjm
she/her
Primary language English
commented
Status: Needs work » Closed (duplicate)

Duplicate of #995156: Use vocabulary machine name for permissions.

xjm’s picture

xjm
she/her
Primary language English
commented
Issue summary: View changes

The correct field that should be used is $vocabulary->machine_name, not $vocabulary->name.