Hi all,
I just noticed that when "Users cannot change email address" is checked, you cannot submit / edit the user form (at /user).
This is caused by using unset() on the $form array, rather than just setting '#access' => FALSE.
WRONG:
Line 926: unset($form['account']['mail']);
RIGHT:
Line 926: $form['account']['mail']['#access'] = FALSE;
Thanks
| Comment | File | Size | Author |
|---|---|---|---|
| #8 | use_access_false_1300998.patch | 1.15 KB | bfroehle |
| #6 | 1300998-fix-hide-email.patch | 1.31 KB | bfroehle |
| #1 | 1300998-fix-hide-email.patch | 1.31 KB | bfroehle |
Comments
Comment #1
bfroehle commentedI assume we should do the same for the other unset calls nearby? Patch attached.
Comment #3
bfroehle commentedHmm, the patch brought back the #1176904: Initial login generates a timezone warning error. Weird. I'll look at this some more when I get a chance, but that won't be for a week or so.
Comment #4
bfroehle commented#1: 1300998-fix-hide-email.patch queued for re-testing.
Comment #5
bfroehle commentedComment #6
bfroehle commentedRe-uploading, but against 7.x-1.x-dev instead of 7.x-1.0. This should fix the testbot errors, I think.
Comment #7
bfroehle commentedCommitted to 7.x-1.x. Thanks for your report.
Should we backport this to 6.x-3.x?
Comment #8
bfroehle commentedHere's the ported patch for 6.x-3.x. Should clean up some ugly code if this actually works... Untested at the moment.
Comment #9
bfroehle commentedAfter some manual testing in 6.x-3.x, I discovered:
* For the password field, setting '#access' to FALSE works properly.
* For the e-mail field, setting '#access' to FALSE hides the form field, but validation errors are thrown if the existing value isn't a real e-mail address. Therefore I've left that code as-is.
Committed to 6.x-3.x.