Version: $Id: acidfree.module,v 1.62.2.53 2006/09/08 20:09:57

On drupal 4.7.6

I've enabled "Printer-Friendly" link on all book pages.
This works fine on the books, but on Albums, which is a node created by acidfree, the link shows up, but clicking on it shows a blank page.

The best fix would be do have printer friendly work (should display images in single column), but it would be fine to act like other nodes that just disable printer-friendly link displays - so no chance for users to click on it.

Comments

vhmauery’s picture

vhmauery commented

Personally, I am not really happy about this one. I think these show up because the book module naively assumes that any node with $node->parent set is a book node rather than actually checking $node->type. Not that it is your fault for bringing it up, but I am not sure what to do about this.

My favorite option would be to submit a patch to the book module that modifies its book_links function to actually check the node type.

bwooster47’s picture

bwooster47 commented

I am fine with even doing this locally on my own box - so where would you put this?

if ($type == 'node' && isset($node->parent) && $node->type == 'book') {

to disable both the "add child node" and "printer-friendly links"
or just add it in the nested if to disable only printer-friendly links?

if (user_access('see printer-friendly version')) {

vhmauery’s picture

vhmauery commented
Project: Acidfree Albums » Drupal core
Version: 4.7.x-1.0 » 4.7.x-dev
Component: Code » book.module

It should apply to both child pages and printer friendly links -- neither one applies to non-book nodes.

While we are at it, I am adding this to the book issue queue so they will see the problem too.

silverwing’s picture

silverwing commented
Version: 4.7.x-dev » 4.7.6
Status: Active » Closed (won't fix)

Unless it's an issue in a current version of drupal, marking as wont fix