For our usage there will be a requirement for term queues to be limited to selecting terms within a single vocabulary. Otherwise the UI will break completely as we have thousands of tags that would be listed, none of which should be selectable.
a. I did not see any new setting to a term queue for a particular vocabulary.
b. I get php timeout when adding a term to a queue. We have a lot of terms across multiple vocabs.
c. The timeout is resolved if terms are added using autocomplete.
The timeout in b. was from includes/form.inc on line 2462 where _form_options_flatten() was unable to flatten the large vocab array.
a) There's an option to limit a term queue to a particular vocab when creating the queue. I've attached a screenshot. This is in a brand new D7 install with only term_queue and ctools modules installed.
b) We need to look at the efficiency of the code in building the drop down box of terms in the term add page. At a glance, I suspect line 183 in term_queue.admin.inc may be the problem here. Unfortunately I'm now on leave until the 24th. Until then Neil (ncameron) will be the point of contact for this.
Sorry Eddie, I did not have a clean install. And I also had the term_queue tables lying around in the db from my first install, which was not uptodate. So after deleting them, and reinstalling the module with the latest rev, this seems to be working fine. Enjoy your leave.
b. I get php timeout when adding a term to a queue. We have a lot of terms across multiple vocabs.
A quick fix for this would be to force users to choose a particular vocab when creating a term queue. We've removed the 'All vocabularies' option from the Limit to vocabulary drop down when creating a new queue. This is pushed to the 7.x-1.x-vocab branch
Comments
Comment #1
eddie_c commentedI've pushed these changes to the 7.x-1.x-vocab branch
Comment #2
girishmuraly commentedUsing the last rev of the vocab branch;
a. I did not see any new setting to a term queue for a particular vocabulary.
b. I get php timeout when adding a term to a queue. We have a lot of terms across multiple vocabs.
c. The timeout is resolved if terms are added using autocomplete.
The timeout in b. was from includes/form.inc on line 2462 where _form_options_flatten() was unable to flatten the large vocab array.
Comment #3
eddie_c commentedHi Girish,
Thanks for the feedback
a) There's an option to limit a term queue to a particular vocab when creating the queue. I've attached a screenshot. This is in a brand new D7 install with only term_queue and ctools modules installed.
b) We need to look at the efficiency of the code in building the drop down box of terms in the term add page. At a glance, I suspect line 183 in term_queue.admin.inc may be the problem here. Unfortunately I'm now on leave until the 24th. Until then Neil (ncameron) will be the point of contact for this.
Comment #4
girishmuraly commentedSorry Eddie, I did not have a clean install. And I also had the term_queue tables lying around in the db from my first install, which was not uptodate. So after deleting them, and reinstalling the module with the latest rev, this seems to be working fine. Enjoy your leave.
Comment #5
girishmuraly commentedComment #6
eddie_c commentedb. I get php timeout when adding a term to a queue. We have a lot of terms across multiple vocabs.
A quick fix for this would be to force users to choose a particular vocab when creating a term queue. We've removed the 'All vocabularies' option from the Limit to vocabulary drop down when creating a new queue. This is pushed to the 7.x-1.x-vocab branch
Comment #7
ncameron commentedok, we've modified the code so that you must choose a vocab id for any given term queue. this should hopefully solve the time out issue
Comment #8
eddie_c commented