Adding Translation Support [#1301560]

Thoughts on adding in translation support to this module?
It could be as simple as adding in the following four lines (although possibly something even easier, although this is what I did since I need it today).

Starting on line 105 on jquery_expander.module

$settings['expandText'] = t($settings['expandText']);
$settings['expandPrefix'] = t($settings['expandPrefix']);
$settings['userCollapseText'] = t($settings['userCollapseText']);
$settings['userCollapsePrefix'] = t($settings['userCollapsePrefix']);

Comment	File	Size	Author
#3	1301560-jquery_expander_i18n-3.patch	1023 bytes	mh86
#1	1301560-jquery_expander_i18n-1.patch	2.08 KB	mh86

Comments

Comment #1

mh86 commented 20 November 2012 at 13:19

Status	File	Size
new	1301560-jquery_expander_i18n-1.patch	2.08 KB

We cannot use the t() function for dynamic strings. Instead a proper i18n field integration is needed.

Attached patch registers the expand and collapse text for translation using the i18n system. The only problem is that I've currently only registered the string for the 'default' view mode. Unfortunately I don't have the current view mode in hook_field_formatter_view() available. Alternatively we could use hook_field_attach_view_alter() (as i18n_field does), and loop over all possible fields and check the formatter, but that seems to be a little performance overhead.