Spawned from #1301542: What happened to theme_uc_cart_checkout_form($form) ?

Should we just remove collapsible fieldsets entirely on the checkout page if collapsing isn't being used anyway? I don't see much use for them except to confuse users who click on the fieldset title by mistake.

CommentFileSizeAuthor
#1 1301600-non-collapsible-cart.patch750 byteslongwave

Comments

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Status: Active » Needs review
StatusFileSize
new 1301600-non-collapsible-cart.patch750 bytes

Trivial patch.

Woggers’s picture

Woggers commented

+1 for supporting this patch. From a usability perspective they are nothing but confusing to the basic user and I get asked time and again to try and remove them.

For the time being I have got around it by just doing some CSS to remove the fieldset and headers entirely:

#uc-cart-checkout-form fieldset legend {
   display: none;
}
tr’s picture

tr commented

#1: 1301600-non-collapsible-cart.patch queued for re-testing.

tr’s picture

tr commented
Status: Needs review » Fixed

Committed.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

chinita7’s picture

chinita7 commented

If somebody wants to disable collapsible pane for D6 this cod from here worked for me.

/**
* Implementation of hook_form_alter().
*/
function example_form_uc_cart_checkout_form_alter(&$form, &$form_state) {
  foreach (element_children($form['panes']) as $pane_id) {
    $form['panes'][$pane_id]['#collapsible'] = FALSE;
  }
}