The first item that facetapi adds to the breadcrumb trail is supposed to have the title of the current page, and the subsequent items will be applied facets. However, sometimes this results in an empty breadcrumb item because the menu router item for the current page doesn't have a title. The patch I'm about to submit just adds a check to make sure the title isn't empty... (though perhaps I should really be looking at why it happens that items in the menu router table don't have titles or whether there's a better way to get the title for the breadcrumb item, but this will have to do for now :-/ The pages in question are views pages, so nothing very edge-casey).

Comments

katbailey’s picture

Here are two versions of promised patch - one rolled with the --no-prefix option and one without.

cpliakas’s picture

Component: Code » User interface
Status: Active » Needs review
Issue tags: +low hanging fruit

Thanks, Kat!

The logic seems right to me, would love to get another pair of eyes testing this as a sanity check. Adding to the "low hanging friut" tag.

~Chris

nick_vh’s picture

Status: Needs review » Reviewed & tested by the community

Looking good! Marked as reviewed & tested

cpliakas’s picture

Status: Reviewed & tested by the community » Fixed

Committed at 3c17d9a.

Thanks!
Chris

Automatically closed -- issue fixed for 2 weeks with no activity.