util.module should adhere to Drupal coding standards. Attached patch adjusts the source code accordingly.

Additionally, IMHO system_modules.inc does not need to be stored in an extra subfolder. You should consider to move the file into /utilities.

CommentFileSizeAuthor
#2 util_1.patch6.17 KBsun
util_0.patch6.55 KBsun

Comments

smk-ka’s picture

smk-ka commented
Status: Reviewed & tested by the community » Needs work

This patch violates String concatenation rules (which were perfect before).

With sincerest regeards,
- Stefan

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Status: Needs work » Needs review
StatusFileSize
new util_1.patch6.17 KB

New patch containing proper string concatenation rules.

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Assigned: Unassigned » sun
Status: Needs review » Fixed

Cleaned HEAD and 5.x.

Anonymous’s picture

(not verified) commented
Status: Fixed » Closed (fixed)