For countries like Australia, all sale prices are inclusive of tax (GST).

Unfortunately, uc_vat and uc_taxes assumes sell price is exclusive of tax, hence applies the tax rate as if it was addititive (eg: 10%, it uses 1.1 or 0.1) instead of 9.0909%. Even though uc_vat supports "inclusive tax price", it does not adjust the tax rate for this calculation.

_Without_ this patch, uc_vat (and uc_taxes) assumes this is how tax is calculated:
sale price exclusive of tax: tax = sale price * tax rate (eg: 10%)
sale price inclusive of tax: tax = sale price * tax rate (eg: 10%)

_With_ this patch, this is how tax is calculated:
sale price exclusive of tax: tax = sale price * tax rate (eg: 10%)
sale price inclusive of tax: tax = sale price * tax rate (eg: 9.090909%)

This also caused a problem with the uc_paypal module (http://drupal.org/node/1300976) where paypal rejects any transactions where AMT != ITMAMT + TAXAMT.

CommentFileSizeAuthor
uc_taxes_inclusive_fix.patch668 bytesdsobon
uc_vat_inclusive_fix.patch603 bytesdsobon
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

ngs_mtech’s picture

ngs_mtech CreditAttribution: ngs_mtech commented

This patch do not handle proprerly complex vat configurations beetween sell prices and order line item taxes-.

My products has tax included, but my shipping line items don't have it.

regards.

sarhansg’s picture

sarhansg CreditAttribution: sarhansg commented

I've run both patches with hopes of fixing my issue (http://drupal.org/node/1368150). I'll try installing 6.x-1.2 and update you on the results.

sarhansg’s picture

sarhansg CreditAttribution: sarhansg commented

Tested the patches and they appear to work. However, they tax amount shown on Cart, Checkout and Review Order pages are still incorrect.

meandrew’s picture

meandrew CreditAttribution: meandrew commented

is there any news on this issue?

meandrew’s picture

meandrew CreditAttribution: meandrew commented

I am finding this incredibly difficult to comprehend why the uc_vat is supported and up to date yet there are so many issues with the module???

Is there a fixed working solution for vat?

Why is there a uc_tax module and a uc_vat module, the vat appears to be for display purposes only?

Thanks

meandrew’s picture

meandrew CreditAttribution: meandrew commented

so the patch doesn't work! how can it appear to work but show the wrong calculations

droomagentur’s picture

droomagentur CreditAttribution: droomagentur commented

for me, those two patches fixed it - thanks a lot, you saved my day!