By rernst on

I've got a question about the intended behavior of the core 'system' module:

When switching to a new theme that has never been activated before, information about the blocks that should appear are copied to the new theme configuration but at the same time, the title values of all the blocks are not copied. What you wind up with is the same block configuration as your old theme, only the blocks have no titles. Is this the intended behavior, or is this a bug?

I've searched the issues, and the forums to no avail. If something already exists that covers this issue, I haven't found it. Part of the difficulty is in describing the problem.

I'd appreciate feedback on the matter. I have a patch to change the behavior -- it's honestly not much of a change -- that I'm willing to submit if it is a bug.

⋅ Categories: Drupal 5.x

Comments

srlinuxx’s picture

srlinuxx commented

I imagine it's a bug. I've been seeing it as well. Why don't you go ahead and post your patch here until you can work out contributing.

--You talk the talk, but do you waddle the waddle?

rernst’s picture

rernst commented

I'm relatively new to drupal, actually, and my main concern was finding a place to discuss the issue. Unlike the contrib modules, there doesn't seem to be an issue tracker (that I can find) for the core drupal modules. I'd prefer to post and discuss it in such a place: any advice as to where to go would be appreciated.

The patch I have is also only against the drupal 5.1 release. I should probably check out the head of cvs and see about applying it there. I'll do that tomorrow.

rernst’s picture

rernst commented

Here's the patch. Very simple. I've also tested it against the CVS head, and it can be applied successfully.

Was generated from our subversion repositories, so if it looks a bit off that's why.

As you can see, I added an extra column to the query, and filled that col with $block['title'].

Index: /home/rernst/svn/drupal/trunk/modules/system/system.module
===================================================================
--- /home/rernst/svn/drupal/trunk/modules/system/system.module  (revision 679)
+++ /home/rernst/svn/drupal/trunk/modules/system/system.module  (revision 680)
@@ -1063,8 +1063,8 @@
       if (!array_key_exists($block['region'], $regions)) {
         $block['region'] = system_default_region($theme);
       }
-      db_query("INSERT INTO {blocks} (module, delta, theme, status, weight, region, visibility, pages, custom, throttle) VALUES ('%s', '%s', '%s', %d, %d, '%s', %d, '%s', %d, %d)",
-          $block['module'], $block['delta'], $theme, $block['status'], $block['weight'], $block['region'], $block['visibility'], $block['pages'], $block['custom'], $block['throttle']);
+      db_query("INSERT INTO {blocks} (module, delta, theme, status, weight, region, visibility, pages, custom, throttle, title) VALUES ('%s', '%s', '%s', %d, %d, '%s', %d, '%s', %d, %d, %d)",
+          $block['module'], $block['delta'], $theme, $block['status'], $block['weight'], $block['region'], $block['visibility'], $block['pages'], $block['custom'], $block['throttle'], $block['title']);
     }
   }
 }
Mapache’s picture

Mapache commented

Your patch is slightly wrong. You're inserting the title as an integer instead of as a string, so all the titles get set to zero (because php tries to read the titles as numbers and fails to parse anything useful out of them).

To fix this, change the last %d you added to '%s' (with quotes). Thus, the amended patch would be:

@@ -1063,8 +1063,8 @@
       if (!array_key_exists($block['region'], $regions)) {
         $block['region'] = system_default_region($theme);
       }
-      db_query("INSERT INTO {blocks} (module, delta, theme, status, weight, region, visibility, pages, custom, throttle) VALUES ('%s', '%s', '%s', %d, %d, '%s', %d, '%s', %d, %d)",
-          $block['module'], $block['delta'], $theme, $block['status'], $block['weight'], $block['region'], $block['visibility'], $block['pages'], $block['custom'], $block['throttle']);
+      db_query("INSERT INTO {blocks} (module, delta, theme, status, weight, region, visibility, pages, custom, throttle, title) VALUES ('%s', '%s', '%s', %d, %d, '%s', %d, '%s', %d, %d, '%s')",
+          $block['module'], $block['delta'], $theme, $block['status'], $block['weight'], $block['region'], $block['visibility'], $block['pages'], $block['custom'], $block['throttle'], $block['title']);
     }
   }
}

This should be changed in the file available from http://drupal.org/node/137072 as well.