Global parameters for all operations of a service

Yes, sounds like a good idea. wsclient_rest.module should save those parameters in $service->settings['global parameters'] or something similar. It has to alter the web service description form to add a similar global parameter input area as for operation parameters. Then it has to check on each operation call if global parameters exist and add them accordingly. Should be pretty straight forward.

The only thing that concerns me is the additional bloat on the form, maybe we should place it in a fieldset or on a separate page.

Anyway, patches welcome.

Subscribing. I'll work with nquocbao to submit a patch.

+++ b/wsclient.inc
@@ -72,6 +72,16 @@ class WSClientServiceDescription extends Entity {
     }
+    ¶

trailing white space

+++ b/wsclient_ui/wsclient_ui.inc
@@ -59,6 +59,25 @@ function wsclient_service_form($form, &$form_state, $service, $op = 'edit') {
+    // global variables table

is a bit confusing. what about "Input for global service parameters"?

You have implemented it for all service types, so I updated the issue title.

Do we want to integrate this in Rules as well? Should the global parameters of an operation be exposed in the Rules action as well so that they could be overridden?

Should we even allow overriding of global service parameters? We could just always rely on the provided default values.

Why would it be better to use $service->global_parameters? We would have to add a DB column to the wsclient_descriptions table then.

I get this error after updating: "Warning: unserialize() expects parameter 1 to be string, array given in EntityAPIController->load() (line 211 of /home/klausi/workspace/entity/includes/entity.controller.inc)." I guess you will have to insert an empty serialized array as default in the update function, for already existing services in the system.

+++ b/wsclient.install
@@ -160,3 +166,15 @@ function wsclient_update_7100() {
+ * Add global_parameters column ¶

trailing white space.

I'm not seeing the warning after applying the patch and running update.php I've tried a couple of the example services. Is the warning happening on a specific page or while running a specific service? I am running the latest dev version of entity however.

Ok, I could not reproduce my error from above, so that should be ok. Trailing white spaces still need to be fixed. All comments should start capitalized and end with a "."

I tested the patch, but could not add any global parameters in the UI. You only add the form elements if global parameters already exist, why?

Then I think we do not need so many columns for global parameters, only "name" and "default value" are relevant. I think we should keep it simple and only allow primitive string global parameters for now, so remove "data type", "multiple" and "required" as they do not make sense here. Also "weight" can be left out.

+++ b/wsclient_ui/wsclient_ui.inc
@@ -164,6 +183,18 @@ function wsclient_service_form($form, &$form_state, $service, $op = 'edit') {
+      $service->global_parameters[$param] = $value;
+      $service->global_parameters[$param]['default value'] = $value['default_value'];
+      unset($service->global_parameters[$param]['default_value']);

why do you need this 3 lines? why can't you just save the form values as they are?

And you should add to the description text of global parameters that they will passed to every single operation in this service description.

+++ b/wsclient.inc
@@ -13,6 +13,7 @@ class WSClientServiceDescription extends Entity {
+  public $global_parameters = array();

class properties should use lowerCamel naming.

+++ b/wsclient.inc
@@ -559,4 +568,4 @@ class WSClientException extends Exception {
-}
+}
\ No newline at end of file

Files should end with the \n character.

+++ b/wsclient_ui/wsclient_ui.inc
@@ -59,6 +59,37 @@ function wsclient_service_form($form, &$form_state, $service, $op = 'edit') {
+    $datatypes = wsclient_ui_types(TRUE);

You don't need the data types anymore, right?

When I create a new REST service I get the following PHP errors:
Notice: Undefined index: global_parameters in wsclient_service_form_submit() (line 201 of /home/klausi/workspace/wsclient/wsclient_ui/wsclient_ui.inc).
Warning: Invalid argument supplied for foreach() in wsclient_service_form_submit() (line 201 of /home/klausi/workspace/wsclient/wsclient_ui/wsclient_ui.inc).

"Specify the global parameters for the services. Global parameters will override the value of operation paramter if parameter value is empty." should be "Specify the global parameters for the service. Global parameters will be used if the value of an operation parameter with the same name is empty."

I think the operations and the data types of a service a more important, so I think the global parameters should come last in the form.

And don't forget to set the status to "neeeds review" if you provide a new patch.

Great, committed and attributed to your account: http://drupalcode.org/project/wsclient.git/commit/6c36d97

some changes:
* update 7200 changed to 7101 (make sure to change the number in the system table!)
* empty() for named parameters replaced with !isset()