Download & Extend
Image Caption » Issues

Set width of div container using image caption input filter with CKEditor

Posted by Shaun Dychko on October 7, 2011 at 5:43pm
Project:Image Caption
Version:6.x-2.5
Component:Code
Category:bug report
Priority:normal
Assigned:Unassigned
Status:needs review

Issue Summary

CKEditor sets the width of images using inline styles instead of with the width attribute of the img tag. The regex in contrib/image_caption_filter needed changing to capture this. Patch is below. This patch will break compatibility with editors that instead set the img tag width attribute.

Login or register to post comments

Comments

#1

Posted by Shaun Dychko on October 7, 2011 at 5:46pm

use the next re-rolled patch instead (not this one).

AttachmentSize
1302780-set-regex-for-inline-syles.patch 465 bytes

#2

Posted by Shaun Dychko on October 7, 2011 at 5:59pm

oh my, sorry, keep going to the next patch... the regex also needs to account for the fact that sometimes spaces follow width: , and sometimes not.

AttachmentSize
1302780-set-regex-for-inline-syles-2.patch 465 bytes

#3

Posted by Shaun Dychko on October 7, 2011 at 5:59pm

here's the patch

AttachmentSize
1302780-set-regex-for-inline-syles-3.patch 464 bytes
nobody click here