Needs review
Project:
Image Caption
Version:
6.x-2.5
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
7 Oct 2011 at 17:43 UTC
Updated:
7 Oct 2011 at 17:59 UTC
Jump to comment: Most recent file
CKEditor sets the width of images using inline styles instead of with the width attribute of the img tag. The regex in contrib/image_caption_filter needed changing to capture this. Patch is below. This patch will break compatibility with editors that instead set the img tag width attribute.
| Comment | File | Size | Author |
|---|---|---|---|
| #3 | 1302780-set-regex-for-inline-syles-3.patch | 464 bytes | shaundychko |
| #2 | 1302780-set-regex-for-inline-syles-2.patch | 465 bytes | shaundychko |
| #1 | 1302780-set-regex-for-inline-syles.patch | 465 bytes | shaundychko |
Comments
Comment #1
shaundychkouse the next re-rolled patch instead (not this one).
Comment #2
shaundychkooh my, sorry, keep going to the next patch... the regex also needs to account for the fact that sometimes spaces follow width: , and sometimes not.
Comment #3
shaundychkohere's the patch