Come together with the global Drupal community in Rotterdam, 28 Sept – 1 Oct 2026. Sessions, contribution, connection, and Early Bird savings until 8 June.We should have the ability to control on what pages the nodejs module should be enabled.
| Comment | File | Size | Author |
|---|---|---|---|
| #8 | control_nodejs_init-1302880-d7-2.patch | 2.34 KB | gitesh.koli |
| #6 | control_nodejs_init-1302880-d7.patch | 2.6 KB | gitesh.koli |
| #3 | control_nodejs_init-1302880-2.patch | 3.49 KB | gitesh.koli |
| #1 | control_nodejs_init-1302880-1.patch | 3.55 KB | gitesh.koli |
Comments
Comment #1
gitesh.koli commentedAttaching the patch for the same.
Comment #2
julien commentedI see where you coming from for this feature. Need to check with Beejeebus if it needs to be on both D7 and D6 version.
Comment #3
gitesh.koli commentedLatest version of the patch attached.
Comment #4
danielm commentedNo news?
Comment #5
Anonymous (not verified) commentedyeah, this looks like a useful feature.
moving to 7.x, where it should go first, then will backport to 6.x.
Comment #6
gitesh.koli commentedUploading the D7 version of the patch.
Comment #7
Anonymous (not verified) commentedgitesh - thanks for the updated patch. can you prepare it from within the module directory, not the site root?
a couple of other things:
- i'd like this to default to always on, with a blacklist, rather than always off, with a whitelist
- the description needs to make very clear that we're going to match system paths, not aliases, so maybe include an example of 'node/23' vs 'content/my-page', which is the most common version of system paths vs aliases
oh, and make sure to set to "Needs review" :-)
Comment #8
gitesh.koli commentedJustin,
I created the patch from within the module directory.
I think people who use this module would prefer a whitelist.
I am thinking maybe we should just add a dropdown for users to select if they want to treat the URL's as a whitelist or a blacklist.
The function we have used to match path's is a built in drupal function and it does match path aliases.
blog/123 would work. There is description on that field about the same.
-Gitesh
Comment #9
Anonymous (not verified) commentedthanks!
http://drupalcode.org/project/nodejs.git/commit/bdfc8af