Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
This project allows users to login on a Drupal website through L2J Server. The module is being under active development for 7.x.
Sandbox: http://drupal.org/sandbox/nonom/1303350
Git repository: http://git.drupal.org/sandbox/nonom/1303350.git
L2j Connect has been running in IsleOfPrayer.org with no issues during a couple of months. This year, we are designing our website/forum to handle at least 10.000 accounts synchronyzed with Drupal 7.x.
Any feedback is welcome
Comments
Comment #1
klausiinfo file is not correct. http://drupal.org/node/542202
Comment #2
nonom CreditAttribution: nonom commentedThanks @klausi, I was replacing by mistake the .info file in the Initial Import.
Fixed now.
Comment #3
klausi* use "Implements hook_xx()" instead of "Implementation of hook_xxx()" , see http://drupal.org/node/1354#hookimpl
* code style: use spaces in assignments, e.g. $var = 0; not $var=0;
* have you run your module through coder to detect code style issues? http://drupal.org/project/coder
* provide a doc block on every function, even if it is short like "submit callback for blabla form"
* line 217 of l2j_connect.module: wrong indentation of db_set_active();
* several other indentation errors (line 177)
Comment #4
nonom CreditAttribution: nonom commentedCommitted the proposed changes in #3.
Thanks again klausi!
Comment #5
nonom CreditAttribution: nonom commentedChanging the status to needs review.
Comment #6
klausiI hate to do this, but some more minor things:
* "Invokes l2j_connect_form_user_login_alter($form, $form_state)" don't repeat the very obvious code. "Implements hook_form_FORM_ID_alter()." alone is fine here
* l2j_connect_user_register_form_validate() does not implement a hook! it is a validation callback. Also on other callbacks.
* code style:
remove the spaces after "(" and before ")". also on other functions.
* README.txt: "Place the entirety of this directory in sites/all/modules/views" what? why? also the other text looks pretty wrong, needs on overhaul.
Comment #7
nonom CreditAttribution: nonom commentedCommitted the proposed changes in #6.
I was experiencing the same issue in #2 with our README.txt, also there was some wrong comments :$
Now is fixed, thanks klausi ;)
Comment #8
klausi* again: l2j_connect_user_register_form_validate() is not a hook implementation, it is a callback.
Comment #9
nonom CreditAttribution: nonom commentedIs committed now, also other minor fixes.
Thanks for your patience reviewing.
Comment #10
klausiAlright, should be good. Some further minor things:
* README.txt: each line should not exceed 80 characters
* module file: @file doc block is missing, see http://drupal.org/node/1354#files
Comment #11
nonom CreditAttribution: nonom commentedThank you very much for your tips. Also committed the proposed changes.
Comment #12
gregglesThanks for your contribution, nonom! Welcome to the community of project contributors on drupal.org.
I've granted you the git vetted user role which will let you promote this to a full project and also create new projects as either sandbox or "full" projects depending on which you feel is best.
Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.