Closed (fixed)
Project:
Google Chart Tools: Image Charts
Version:
7.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
8 Oct 2011 at 18:14 UTC
Updated:
26 Feb 2012 at 18:29 UTC
Jump to comment: Most recent file
Comments
Comment #1
johnvAttached patch solves the issue.
Comment #2
13rac1 commentedThis makes sense. I'll test/apply/commit on Monday.
Comment #3
wojtha commentedTested
Comment #4
eMPee584 commentedThe patch does fix the notices as advertised, however there was another:
coming up on the admin/reports/charts/watchdog path, and i ended up completely reshuffling the chart_unique_color() function, the logic should be more clear now. Also added a grey color entry to the watchdog color scheme. Attached diff contains previous patch.
Comment #5
13rac1 commentedUpdated patch needs review.
Comment #6
eMPee584 commentedTrue, true... ;)
Comment #7
danreb commentedIt Works!
I applied the patch and it works and removed the notice and warning, thanks!
Comment #8
danreb commentedOh I almost forgot, I applied the patch in #4 by eMPee584
Comment #9
eMPee584 commented@danreb: did you push it live? because i can't see nothing here...
Comment #10
danreb commented@eMPee584 : I applied your patch in #4 on the website that I am developing and it fixed the problem of:
and
so I changed the status to RTBC so that the module maintainer can look at the patch and commit it and push it live.
Comment #11
eMPee584 commentedOk lol sorry, my misreading: you are NOT the chart maintainer. Nevermind, and thx for reviewing ;-)
Comment #12
13rac1 commentedApplied to 7.x-1.x-dev. Thx!
Comment #13
cskli911 commentedit's work for me, thk you.
Comment #15
dgastudio commentedsame problem, same solution. thank u.
can this be commited ?
Comment #16
13rac1 commentedIt has already been committed to 7.x-1.x-dev. I'll consider making a new release next week.