The "url_processor" key has an underscore, which is not consistent with how other keys are formulated. They all use spaces instead.

CommentFileSizeAuthor
#5 facetapi-1304010-5.patch2.93 KBcpliakas

Comments

cpliakas’s picture

cpliakas commented
Issue tags: +low hanging fruit

Adding "low hanging fruit" tag.

foopang’s picture

foopang commented
Component: Code » Code (functionality)

Hi, how could I contribute to this module?

Is this issue solved? I couldn't find the "url_processor" key in hook_facetapi_search_info()?

cpliakas’s picture

cpliakas commented

Hi beansboxchrispang.

Thanks for your interest in contributing. Take a look at the facetapi_get_searcher_info() function for where the discrepancy is. You will see that the other items such as "supports facet missing" and "supports facet mincount" have spaces instead of underscores. The "url processor" key also has to be documented in the doc blocks, as I just noticed that it is missing.

Thanks,
Chris

cpliakas’s picture

cpliakas commented

This key has to be documented in the hook_facetapi_searcher_info() function in the facetapi.api.php file as well.

cpliakas’s picture

cpliakas commented
Component: Code (functionality) » Code
Status: Active » Needs review
StatusFileSize
new facetapi-1304010-5.patch2.93 KB

Attached patch makes the change.

cpliakas’s picture

cpliakas commented
Status: Needs review » Fixed

Resolved in commit http://drupalcode.org/project/facetapi.git/commit/052a3c8.

Automatically closed -- issue fixed for 2 weeks with no activity.