If a group administrator marks a wiki as "sticky" inside of a group, normal users cannot edit the post because they receive an error massage "You can only make posts sticky for a group you are an admin for.". See the attached screenshot.

CommentFileSizeAuthor
#2 commons_core-group-sticky-prevents-edits-1304386.patch1.88 KBmstef
sticky-wiki-error.jpg73.96 KBcpliakas

Comments

mstef’s picture

mstef commented

I see the problem. Working on a patch now.

The issue is that the code enforces that group stick only be used by group admins, despite default permissions not making the group sticky field visible. So, since it is sticky, on validation, it shows that a non group admin is saving it as sticky.

What I propose doing is only doing the validation if it's actually being changed to sticky - meaning that the node, as it stands, is currently not sticky.

mstef’s picture

mstef commented
Status: Active » Needs review
StatusFileSize
new commons_core-group-sticky-prevents-edits-1304386.patch1.88 KB

Patch

ezra-g’s picture

ezra-g commented
Status: Needs review » Fixed

Looks good and resolves the issue in my brief testing.

Committed - Thanks!

http://drupalcode.org/project/commons.git/commit/88ad83f

ezra-g’s picture

ezra-g commented
Title: Normal users cannot edit a wiki once a group administrator marks it as "Group sticky" » Non-admins cannot edit a wiki once a group administrator marks it as "Group sticky"

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.