Doesn't work with new image.imagemagick.inc?

herb - March 23, 2007 - 14:38
Project:Image Enhanced Scaling
Version:5.x-1.x-dev
Component:Code
Category:bug report
Priority:normal
Assigned:zoo33
Status:closed
Description

Thanks for your work on this module. I tried to use it with previous versions of image on a windows machine although there were some issues, I could see that it really improved the thumbnail sized images.
The new image.imagemagick.inc modifed in http://drupal.org/node/127863 fixes the issues with using imagemagick on my WAMP development setup, but seems to break this module.
Would this module be maintained to develop the improved scaling functionality, or should the functionality go somewhere else?
I'm pretty new to this, so I'm not sure where to ask.
Thanks

#1

zoo33 - March 23, 2007 - 15:52

If Image enhanced scaling is broken with the current version of image.imagemagick.inc then we need to fix it. Just how broken is it? It it's unusable then this is a critical bug.

I'll look into this later.

#2

zoo33 - March 25, 2007 - 00:18
Assigned to:Anonymous» zoo33
Status:active» needs review

I just committed a new version which should work with the current version of image.imagemagick.inc (as well as older ones). Please try the dev version and see if it works!

Feel free to mark this as Fixed if it does work. Thanks!

#3

herb - March 25, 2007 - 13:35

I just tried it using "todays" image and image_enhanced_scaling. Copied the new image.imagemagick.inc to includes as normal. Did the database update that image requested and created an image with the imagemagick toolkit. All was well.

Enabled Image Enhanced Scaling. Previewed a new image and it looked OK. Submitted it and got the following error:

Fatal error: Call to undefined function: _image_escape_shell() in C:\wamp\www\testsite.com\sites\all\modules\image_enhanced_scaling-5.x-1.x-dev\image_enhanced_scaling\image_enhanced_scaling.module on line 274

Am I using a wrong version of something - I'm using a WAMP setup with Apache 2.0.59 MySQL 5.0.2.7 - PHP 4.4.4
I have ImageMagick installed at c:\imagemagick and it's the latest ImageMagick-6.3.2-1-Q16-windows-dll.exe.

Thanks

#4

zoo33 - March 25, 2007 - 20:45

The error message suggests that you're still using the old version of image_enhanced_scaling.module. It might take a few more hours until the dev version on the download page is updated.

Check the revision number on line 2 of image_enhanced_scaling.module. The new version is revision 1.9.2.4.

#5

herb - March 26, 2007 - 11:31

Just tried to get it again, but I'm still getting v 1.9.2.3 2007/03/24 23:33:24 zoo33.
Is there some other place to download the latest version or do you think it still needs to update?

#6

zoo33 - March 26, 2007 - 13:29

You're right, the -dev tarball isn't updated yet, which is weird. I think the package script may have been confused somehow, because the version that's been packaged was committed just one hour before the last version. Also, that last commit was done 14 minutes after midnight, which may be when the script is running.

I'll do a dummy commit and see if that triggers it. Try again tomorrow, or grab the file from CVS.

#7

herb - March 26, 2007 - 13:53

I got v 1.9.2.5 2007/03/26 13:33:42 from CVS and it seems to work great. Thanks for your help!

#8

zoo33 - March 26, 2007 - 14:32
Status:needs review» fixed

Great! Thanks for reporting this.

#9

Anonymous - April 9, 2007 - 14:47
Status:fixed» closed
 
 

Drupal is a registered trademark of Dries Buytaert.