We have test failures. Our first D8 core breakage. http://qa.drupal.org/pifr/test/139719.

I think we should require Examples to pass cleanly with any commit.

Comments

Mile23’s picture

Mile23
Primary language English
Location Seattle, WA
CreditAttribution: Mile23 commented

Well there's that whole 'moving target' thing... It seems as though the 8.x branch should maybe just be 8.x-dev-dev, as opposed to 7.x which is just 7.x-dev. :-)

What are your thoughts on making a stable 7.x branch and a dev branch for 8.x, so people understand the distinction?

rfay’s picture

rfay
Primary language English
Location Palisade, CO, USA
CreditAttribution: rfay commented

I've never thought of having a stable release, and am not sure what purpose it serves. Mostly I don't want people installing this on live servers. However, your point has validity.

That wouldn't get us out of the trouble of having to chase head with 8.x though. It's just part of the game. Examples is typically the first contrib to work with core, and it serves great purpose there. But it's a pile of pain. I hope we can do it.

rfay’s picture

rfay
Primary language English
Location Palisade, CO, USA
CreditAttribution: rfay commented
Title: Contextual links, theming, and render test failures » [critical] Contextual links, theming, and render test failures
rfay’s picture

rfay
Primary language English
Location Palisade, CO, USA
CreditAttribution: rfay commented
Title: [critical] Contextual links, theming, and render test failures » [critical] Theming Example and Render Example are broken
Component: Contextual Links Example » Render Example

Spinning off Contextual links into its own #1310536: Contextual Links Example completely broken (Edit object doesn't work in block)

Both the remaining issues (Render and Theming) are a result of #1283892: Let Render API fail in a tale-telling way on invalid $element as far as I can tell.

You get something like this when visiting any of the relevant pages:
User error: "0" is an invalid render array key in element_children() (line 6166 of /home/rfay/workspace/d8git/includes/common.inc).

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
CreditAttribution: tim.plunkett commented

From render_example.module:

This #theme function has the responsibility of consolidating/rendering the children's markup and returning it, where it will be placed in the element's #children property.

From drupal_render():

Children are all elements whose keys do not start with a '#'. Their values should be renderable arrays themselves.

So, just because a theme function is responsible for the children, doesn't mean the children can't be renderable arrays.

I'm kinda stuck on how to best update this example without it starting to look like the following one, with two children containing #markup.
But I'm not sure that the intent of this example is so wrong that it should just be removed.

rfay’s picture

rfay
Primary language English
Location Palisade, CO, USA
CreditAttribution: rfay commented

Thanks so much for your attention to this, @tim.plunkett

As we were discussing last night, we don't have to "fix" any example. Rather, we just need to find ways to demonstrate crucial concepts that people need. So if this is a bogus demonstration, let's replace it with something better. It does not even have to bear relationship to what we have here.

rfay’s picture

rfay
Primary language English
Location Palisade, CO, USA
CreditAttribution: rfay commented
Version: » 7.x-1.x-dev
Status: Active » Fixed

8.x-1.x branch has started over, so we'll call this fixed.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.