Closed (fixed)
Project:
Token Filter
Version:
7.x-1.0
Component:
Documentation
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
10 Oct 2011 at 10:40 UTC
Updated:
11 May 2020 at 22:44 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
Screenack commentedJust installed token filter for a new project, and I forgot that the README in the package is outdated, as per this issue I submitted. Reading my own note here reminded me of the correct way to implement token filter. I'm curious why this isn't being incorporated?
Comment #2
capynet commentedAdd patch
Comment #3
capynet commentedI'm sorry, discard previous patch, bad formatted. here is the correct.
Comment #4
phanos commentedlooks good to me
Comment #5
johnhorning commentedLooks like this still needs to be committed.
Comment #6
darvanenIf we're going to send people to the help page for tokens instead of listing the ones that are commonly available (global tokens) there needs to be a large notice regarding context.
Users are frequently trying to use tokens out of context, like using a node token inside a block.
Comment #7
osopolarFWIW: If the token people want to have access is the current-page content object. issue #919760: Add a [current-page:object:?] dynamic token may help them to achieve what they are looking for. Maybe it's worth to mention that in the README file.
Comment #8
darvanenI wasn't aware of that issue, thanks for linking, it would be a HUGE improvement.
It wouldn't stop people using the wrong tokens though, just provide a good alternative.
Comment #9
volkswagenchickComment #10
volkswagenchickComment #11
volkswagenchickComment #12
colorfulcoder commentedI noticed that the README.txt was outdated because it tells the user to go to /admin/settings/filters and that didn't work for me.
I wanted to create an issue for it but I see that this one already exists. Lovely!
I saw the patch and I have one thing to say about it, although it is nitpicky:
I would use https instead of http. I know it will get redirected anyways, but it's just good practice.
I would make a new patch and diff, but I find that my diff files always get messed up and don't work :( And since it's such a small difference I thought it'd be ok to just mention it like this.
Comment #13
volkswagenchickLine breaks at 80 characters, please.
Comment #14
kamalparyani commentedAdded Line Breaks at 80 characters.
Comment #15
volkswagenchickThanks for updating. The last patch is incomplete.
Please review documentation: https://www.drupal.org/docs/develop/documenting-your-project/readme-temp...
Here is a summary of the preferred format for README.txt:
Headings in all caps.
Headings underlined with ===/--- to the length of the heading, followed by a blank line.
Two lines prior to headings (except the first one).
Bullets denoted by asterisks (*) with hanging indents.
Numbered lists indented 4 spaces.
Bulleted lists indented 1 space.
Text manually word-wrapped within around 80 cols.
Comment #16
Webbeh#14 appeared to ignore the work of #2 and #3, so fixing #3 given the requests on #15. Rerolled patch based on changes and interdiff from 3->16.
Comment #17
volkswagenchickThanks @Webbeh for the updated patch and interdiff.
I reviewed the readme file for grammar, spelling, formatting, and readability.
Links are all valid.
The configuration is correct.
Patch applied locally. Marking RTBC
Comment #19
darvanenThanks all :)