flagging-user sub-tokens not replaced

Updating title for accuracy. I haven't tried to use the flagging-user token in Drupal 7 yet, but if [flagging-user:name] works then it should work for all Field module fields also.

They are. I guess though the problem is that the global user object is taken, which is no full entity. Attached patch should fix it, please test.

Ah right. I actually just ran into this earlier this week that the global $user is not a full entity. Thanks for the patch, I imagine it should work, but if @dkliewer can confirm that would be great.

Looks like the code has moved into flag_flag.inc but the fix still works. Here's a re-roll.

Thanks for the reroll. Committed to 3.x.

Fixed on 7x-2x too.

Hmmmmm hang on.

This is adding a full user_load() right at the top of the process, for tokens we might or might not need.

Would it not be better for performance to leave this off until Rules is invoked (if it exists)?

Similarly, when we replace our own tokens for our own labels, we lazy-load the flagging entity:

  function replace_tokens($label, $contexts, $options, $entity_id) {
    if (strpos($label , 'flagging:') !== FALSE) {
      if (($flagging = $this->get_flagging($entity_id))) {
        $contexts['flagging'] = $flagging;
      }
    }
    return token_replace($label, $contexts, $options);
  }

Should we not take the same approach for the user here?

Hmmyup, on further reflection, I'm not happy with this fix. I don't think it's a good thing to be adding an extra entity load to the flag pathway, which is used on AJAX.

Reverting the commits.

Drupal 7 is EOL. Issue will be closed, but patches are still here