IP-form needs validation, that it is actually and IP-address that get's entered.

This needs, however, first this task to be completed.

CommentFileSizeAuthor
#2 1304842-2.patch3.42 KBroderik
#1 1304842-1.patch2.9 KBroderik

Comments

roderik’s picture

roderik
Primary language Dutch
Location Amsterdam,NL / Budapest,HU
commented
Status: Active » Needs review
StatusFileSize
new 1304842-1.patch2.9 KB

Credit csg. (I'm just separating a few patches.)

roderik’s picture

roderik
Primary language Dutch
Location Amsterdam,NL / Budapest,HU
commented
StatusFileSize
new 1304842-2.patch3.42 KB

Obviously this doesn't do much if I forget to include $form['#validate']...

bfr’s picture

bfr commented

Thanks, i will check and commit these this evening. By the way, it is recommended that you create patches with git format-patch, then the credit goes in automatically. Just for the future, these are ofcourse fine also.

bfr’s picture

bfr commented
Status: Needs review » Fixed

Commited, thanks for the contribution!

bfr’s picture

bfr commented

By the way, i just noticed i mis-thinking in this patch. You actually SHOULD be allowed to enter your own ip-address.
Think a situation where you want to ban ALL except your own address. With this patch you are not able to a) Whitelist you own address b) blacklist range that includes your own address.

Maybe it should trigger a warning in the confirmation page instead of failing validation?

However, this needs a new issue since this patch is already in.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

bfr’s picture

bfr commented

I changed the validation a bit in the latest release.