SMS Sendega

please add a link to your sandbox :)

thanks, changing back to need review

Hi ramsalt,

I see a lot of coding standards issues. Please run this through Coder in the minor setting, fix what it shows, then set this back to "needs review".

@ramsalt has been contacted to ask if the application is abandoned.

After ten weeks with a status of needs work: the applicant may be contacted by a reviewer to determine whether the application was indeed abandoned. The action taken by the reviewer should be documented in the project application issue.

http://drupal.org/node/894256

Manual test

Master Branch

It appears you are working in the "master" branch in git. You should really be working in a version specific branch. The most direct documentation on this is Moving from a master branch to a version branch. For additional resources please see the documentation about release naming conventions and creating a branch in git.

Automated Test

PAReview.sh check is not ok: http://ventral.org/pareview/httpgitdrupalorgsandboxramsalt1300020git

@NBZ4live , please do not post the output of a automated test as a comment, attach it, or link to the online version. Also, does not mark as need work without doing a manual review after the applicant have corrected issues after a automated test.

@MiSc, sorry for the big comment. I replaced it by the link to the online report.
But the problem with the branching I have seen before the automated test and there is only the master branch with some tags:

$  git branch -a
* master
  remotes/origin/HEAD -> origin/master
  remotes/origin/master
$  git tag
6.x-0.1
6.x-0.2

So it definitely needs work.
And I think you agree, that a complete manual review of the code doesn't make sense when there are so many problems seen by the automated test like this:

• The "?>" PHP delimiter at the end of files
• CVS tags
• ERROR | TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false"

Closing due to lack of activity. Feel free to reopen if you are still working on this application.

Added a link to the sandbox