Hi,

I get this warning on every product page.

Strict warning: Only variables should be passed by reference in function taxonomy_menu_trails_init() (line: 80 in file /home/users/User/example.com/web/sites/all/modules/taxonomy_menu_trails/taxonomy_menu_trails.module).

Is there anything I can do about that?

Thank you, Martin.

CommentFileSizeAuthor
#1 1305956-fix-strict-warning-when-loading-entity-in-hook_init.patch1.44 KBdmitriy.trt

Comments

dmitriy.trt’s picture

dmitriy.trt commented
Status: Active » Needs review
StatusFileSize
new 1305956-fix-strict-warning-when-loading-entity-in-hook_init.patch1.44 KB

Hi,

There are two solutions:

  • Exclude E_STRICT from error_reporting in php.ini. On production server it is not recommended to show E_STRICT warnings anyway.
  • Apply attached patch to 7.x-1.2 or wait for the next packaged 7.x-1.x-dev (script checks git for changes twice a day)

If you want to help fixing this upstream, please use the second method and leave comment here about results. And after the test I recommend you to disable E_STRICT if this is production server. Thanks for your help.

dmitriy.trt’s picture

dmitriy.trt commented
Title: String warning: taxonomy_menu_trails_init() » Strict warning: taxonomy_menu_trails_init()
Status: Needs review » Fixed

Fixed in 7.x-1.3 release.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.