Active
Project:
Google Chart Tools: Image Charts
Version:
7.x-1.x-dev
Component:
Code
Priority:
Critical
Category:
Feature request
Assigned:
Unassigned
Reporter:
Created:
11 Oct 2011 at 11:31 UTC
Updated:
9 Nov 2014 at 22:45 UTC
Jump to comment: Most recent
Comments
Comment #1
13rac1 commentedThank you for your code/effort. The new JS version of Google charts is currently not supported by this module.
Your module looks like it would work, but needs a lot of work. The code does not follow the Drupal coding standards, and unless it is going to be feature complete rewrite it should be submitted as a patch against the current 7.x-1.x HEAD branch.
Changing the title, because it doesn't describe the issue, and the module works correctly on D7 (for the image API).
Setting to duplicate, because it is a duplicate of #1196712: New Interactive Google Charts API?.
Comment #2
SanDiego commentedWell, #1196712 already refers to this thread as duplicate and states that the solution exists here. See http://drupal.org/node/1196712#comment-5103826
Comment #3
13rac1 commentedI wrote that comment on that thread one minute after this one. I don't understand what you are trying to say.
Comment #4
daniorama commentedIs this going to be included in Chart module or is it going to remain as a "ronin" solution?
Comment #5
13rac1 commented@daniorama: The code attached needs a LOT of work and needs to be a patch before it can be applied to the Chart module. If someone takes it upon themselves to complete the attached code and make a working patch, I'm happy to commit it.
Comment #6
Pierre.Vriens commentedI'm reopening this issue (and changing the priority!) in attempt to get feedback about the feasibility of this proposal: how about using this issue as a starting point for providing an upgrade path from chart 7.x-1.x (maybe also 6.x-1.x if possible ...) to chart 7.x-2.x (maybe also 6.x-1.x if possible ...)? In my opinion it already contains quite some interesting contributions to start from!
If that makes sense, I suggest to update the issue title to something like 'Upgrade to chart 2.x module'.
I look forward to feedback about my proposal here (and thumbs up for it). Without anything like that: sorry for asking, I'll restore the previous metadata about this issue (and might create another wake-up call issue for those +25K sites still using chart ...).
Note: be aware of my related updates in #1196712: New Interactive Google Charts API?, as a potential alternative to consider by those +25K sites still using chart today.
Comment #7
Pierre.Vriens commentedJust discovered another issue related to this ...
Comment #8
Pierre.Vriens commented