Group Checkboxes Appear on Form Edit when "Audience checkboxes" is unchecked

Thanks. I am a developer, but I've never used form_alter before, don't know the name of the form, the form id, or even if I did, how to tell whether the process is is a "create" or "edit".

All I want to do is display the same thing (audience defaults to current group, no checkboxes) on "edit" form as is displayed on "create" form.

I found og_form_alter($form_id, &$form). As far as I can tell, it calls og_form_add_og_audience($form_id, $form) where it appears the form is actually built. Assuming I'm right so far, I can't tell from this code how you tell a "create" process from an "edit" process.

Or, am I looking at this all wrong? Can someone who knows what should be done please help? Thanks.

OK, absent any clear direction, what I did here was create a debug snippet that wrote out various values from the og_form_add_og_audience function so I could compare the "create" process with the "edit" process. The difference I found was that when a user creates a group node, there is a value in gids. When a user clicks on the link to edit a node, there is no value in gids. So, I figured I could remedy the situation by placing the current group nid in gids, like so:

/**
 * Helper method to add OG audience fields to a given form. This is
 * lives in a separate function from og_form_alter() so it can be shared
 * by other OG contrib modules.
 */
function og_form_add_og_audience($form_id, &$form) {
  global $user;
  if ($_SERVER["REQUEST_METHOD"] == 'GET') {
    $gids = $_GET['gids'];
  }
  elseif ($_POST['og_groups_hidden']) {
    $gids = unserialize($_POST['og_groups_hidden']);
  }
//
// Modification
// 
// If this is a node edit and we don't have already gids and there is a group context, then use
// current group context as gid[0]
//
	$group_node = og_get_group_context();
	if (arg(0) == 'node' && is_numeric(arg(1)) && arg(2) == 'edit' && IS_NULL($gids) && ($group_node)) {
		$gids[0] = $group_node->nid;

	}
//
...

See any problems with this?

That's not true. First off, if a site administrator wants to limit a user to post only to his current group, he will hardly want to give that same user the ability to re-edit that same post into another group. That simply defeats the purpose of having an "Audience checkboxes" option in the first place.

That said, if the site administrator wants to allow users to post to more than one group, and thus re-affiliate posts, then he simply checks the "Audience checkboxes" box in OG config. If "Audience checkboxes" is checked, even with my modification, the group checkboxes will appear on content creation AND edit forms.

The way OG now works by design, a site administrator can never restrict a user (who belongs to more than one group) to post to only his current group because the user can always re-affiliate his initial post with another group using the edit process. The way OG works with my modification is that a site administrator can now truly restrict a user to posting to just his current group OR optionally allow the user to post to any groups he belongs to.

Furthermore, if the site administrator places a "current group only" restriction on user posts, and a user, seeing the current group clearly in the "Audience" section of the submission form, still submits the content to the wrong group, he can always delete the submission and re-submit to the correct group. So, it is possible for a regular user to correct a mistake. And, if he has to do this a couple times, he'll learn to pay better attention to the group he's posting to. Win-win if you ask me.