Function page_title_get_title() now has own cache, which breaks default page title if the token was processed too early. This is a problem similar to #529186: Usage of global token breaks default page titles because of early Token caching but caused by the Page Title itself.

I see no point in having the title cache. Even more, I see no point in the function being called before theme preprocessing. Any value calculated before page theme processing will be wrong anyway, so why waste cpu cycles calculating junk ? There should be one, and only one place where the page title tokens are processed: page template preprocessing.
I suggest to have special flag which tells Page Title tokens "hey, we are in the final stage, lets do the real job". Without this flag set, Page Title would return just empty string instead of a token.

CommentFileSizeAuthor
#1 page_title_remove_cache_1306206_1.patch1.79 KBcrea
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

crea’s picture

Status: Active » Needs review
FileSize
1.79 KB
crea’s picture

The patch above didn't remove the static cache though. It's much better to postpone the token processing so having the cache should bring no harm. Maybe it's not needed at all. In a worst case, it's neither harmful, nor useful.

chinita7’s picture

Thanks #1 works for Panels page and FAQ page.

darora’s picture

#1 patch made it work for me too..Thanks.