Unique titles restrict over other node types
Southpaw - March 24, 2007 - 04:37
| Project: | Wikitools |
| Version: | 5.x-1.x-dev |
| Component: | Code |
| Category: | bug report |
| Priority: | normal |
| Assigned: | rötzi |
| Status: | closed |
Description
I created a node type called 'wiki page' and selected just that under the selection for 'Wiki node types'
I then checked the Unique titles option.
I have a book page called 'Test'
I am now unable to create a page called 'Test' using the 'wiki page' as an error shows that there is already a node type called 'Test'.
I would have expected the Unique titles only to be restricted to 'wiki page' as that was the only node type I selected.
(I am also using the Freelinking filter (hijacked))
#1
Thanks for the report. This will be fixed in the next version.
#2
was this ever fixed? I'm using the lastest 5.x dev version and I'm having the exact same problem?
#3
This is fixed in dev releases after January 5th as well as in the 5.x-1.1 version. Reopen this if the problem persists with the newest version.
#4
There are no commits in the CVS log after January 4th (which only applies to 5.x branch) and there is also no dev release for 6.x, maybe you could add this so that testing is easier.
#5
Upon further look, yes, you're right, it appears rötzi never fixed this. I will be submitting a patch shortly.
#6
Not sure if this is actually a problem as I couldn't reproduce it. The code looks like it already deals with this:
function wikitools_node_validate($node) {if (wikitools_type_affected($node->type)) {
if (wikitools_enforce_unique_titles()) {
..
}
}
}
#7
The actual problem is that in the db_query, node types are not restricted to just wiki content types.
#8
I fixed this bug in the 5.x and 6.x version. The patches are attached.
The 6.x patch has three other small changes not related to this bug:
- fix of http://drupal.org/node/222030
- moving of menu hijacking into 'hook_menu_alter'
- fix of 'create form' stuff if there are multiple node types active (although it has still a bug)
#9
Awesome! Glad to see you're back into maintaining this :D.
It appears no patches were attached for some reason :)
#10
ok, second try.
#11
Commited in DRUPAL-6--1 branch and DRUPAL-5 branch.
#12
Automatically closed -- issue fixed for two weeks with no activity.