Posted by DanielF on October 11, 2011 at 10:41pm
7 followers
| Project: | Administration menu |
| Version: | 7.x-3.x-dev |
| Component: | User interface |
| Category: | feature request |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | active |
Issue Summary
Drop shadows are cool, but the drop shadow on the stylized toolbar provided by the Toolbar Style submodule is just ridiculous, and has actively disrupted work on a couple of themes that had along-the-top style toolbars themselves.
A checkbox that let's me turn that on and off would be most welcome--it's really annoying to build a CSS override into my themes.
Comments
#1
Ok, I went ahead and did this. Please review.
#2
The last submitted patch, 1306626-toggle-option-for-drop-shadow.patch, failed testing.
#3
That was a bad eol fail. Going again.
#4
#5
The last submitted patch, 1306626-toggle-option-for-drop-shadow.patch, failed testing.
#6
I don't get it, the admin_menu.test is indeed broken in the 3.0-rc1. I patched it up after finding #1146644: Admin Menu: Test: PHP 5.3 compability for parent::setUp callback, and now the tests on my local installation pass without a problem. I really don't know what to do with this.
#7
I don't think a checkbox is the right approach. What exact issue are we trying to resolve?
#8
The problem is the drop-shadow of the admin menu (interferes with themes some times). There are two ways to toggle something, checkbox or radio buttons. Checkboxes are used for the rest of the toggles in the Admin menu configuration so I went with that. That configuration setting is in reality a mere convenience setting since the same can be achieved by editing the
admin_menu/admin_menu_toolbar/admin_menu_toolbar.cssfile.#9
What we need to know is when exactly the shadow interferes with a theme, and more importantly, why.
And then, the next best question is whether the shadow of the core Toolbar module also interferes with the theme.
Unless absolutely required, we should not add a configuration option for the shadow - that would be way too technical/special.
#10
Putting it like that really turns this issue into a non substantial one.
I don't have serious background in usability issues nor I am a themer; but I can see the problem a themer might have with the drop-shadows found in both the Administration Toolbar module and the core Toolbar module. In such a specific user case, removing the drop-shadow is a no-brainer so that should not be a "burden" (aka extraneous configuration item) to the rest of the users of the module.
IMHO on these terms, this can be closed. DanielF should be given a chance/some time to enforce the case he is making.
#11
My apologies for the long delay in answering this. Here was my situation:
The theme I was developing at the time had its own toolbar. The drop shadow provided by the Toolbar theme, as you can see in the attached image, covered the toolbar of my own theme, which was annoying and could only be fixed by disabling the Toolbar theme.
I would add that, if according to #9, a checkbox must be avoided if at all possible, then it seems it would be best to remove the drop shadow entirely. It looks nice, which is good, but if it covers up anything that shouldn't be covered, then it's getting in the way, and no longer serves an useful purpose.
#12
Let's do #1022902: Align Better Toolbar style with core Toolbar style first and then see whether this is still required.
#13
#14
FWIW, #1683132: Extra 20px padding causes horizontal scrolling will make the shadow a lot smaller and less disturbing. Perhaps that might be sufficient already?
#15
I just spent 5 minutes searching for how to disable the shadow and found this thread. As a designer I really like to see what the actual top of my page looks like. I don't want to have to login as anon to do that. It would be great to have an option to remove the shadow altogether as it lays itself on top of the design of the site.
#16
Shouldn't we be using CSS for shadows now, instead of images?
Removing the
#admin-menu-shadowdiv and adding this to#admin-menu-wrapperseems to work just as well, in Opera at least:#admin-menu-wrapper{
box-shadow: 0px 5px 10px rgba(0, 0, 0, 0.8);
}
#17
Agreed. The shadow on this menu adds nothing to the usefulness and continually frustrates me when I am developing themes. I would love to be able to turn this off or have it permanently disabled.