Hi,

Just to be sure someone thinks about integrating it, I'm providing the patch to export variables created by #1211008: Split field_bundle_settings out per bundle ;-)
Now, we just wait for that patch to be integrated into core (please help!).

CommentFileSizeAuthor
strongarm_1211008_follow_up.patch420 bytessimon georges

Comments

yched’s picture

yched commented

I'm not familiar with the syntax in strongarm_features_pipe_node_alter(), just pointing out that #1211008: Split field_bundle_settings out per bundle uses double undescores : field_bundle_settings_[entity_type]__[bundle]

simon georges’s picture

simon georges commented

@yched, looking at other variables, the underscore is removed, therefore I've removed one (it's automatically added by the function elsewhere). At the end, both underscores should be here (but I haven't actually tested it, so...).

wojtha’s picture

wojtha commented
Status: Needs review » Reviewed & tested by the community

It works for me. Thanks!

(Using the patch in #1211008-32: Split field_bundle_settings out per bundle)

mrfelton’s picture

mrfelton commented

Works for me too. Good stuff.

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented
Status: Reviewed & tested by the community » Postponed

Sure, this works great, but only after #1211008: Split field_bundle_settings out per bundle is in.

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented
Issue tags: +D7 stable release blocker

Tagging, #1211008: Split field_bundle_settings out per bundle is now RTBC and might even get into 7.13

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented
Issue tags: -D7 stable release blocker

The next stable release of core is May 2nd. (just pushed back http://groups.drupal.org/node/220304)
And field_bundle_settings isn't used yet, this just an addition.

simon georges’s picture

simon georges commented
Status: Postponed » Reviewed & tested by the community

Yeah, this has been committed to core ;-)

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented

7.14 has now been released with this fix.

bojanz’s picture

bojanz commented
Status: Reviewed & tested by the community » Needs review 
field_bundle_settings_node_

Doesn't this make it work for nodes alone?
What about other entity types?

bojanz’s picture

bojanz commented
Status: Needs review » Reviewed & tested by the community

Nevermind, this was node specific code.

mpotter’s picture

mpotter commented

Looks good to me. Committed and pushed to 895016e.

mpotter’s picture

mpotter commented
Status: Reviewed & tested by the community » Fixed
simon georges’s picture

simon georges commented

Yay ! Thanks.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.