when the signature module and quote module are used together, a problem exists. The signature module is supposed to remove the signature from the textfield in the edit/comment form, and does so correctly when you only click reply. When you click quote, the signature still shows up in the textfield, after the quote. I don't know if whether this is a problem with quote or with signature, but my guess is it has something to do with what quote does to keep the signature (when signature module not installed) out of the quote itself.

Comments

danroth’s picture

danroth commented

I logged in to shed light on the same issue.

deadman’s picture

deadman commented

I've solved this issue for replying to comments:

I replaced the following code in quote.module (line 160):

    $form['comment_filter']['comment']['#default_value'] = '[quote='. $author .']'. $quote ."[/quote]\n". $form['comment_filter']['comment']['#default_value'];

with:

    $form['comment_filter']['comment']['#default_value'] = '[quote='. $author .']'. $quote ."[/quote]\n". $form['comment_filter']['comment'][''];

This stops the module capturing the signature as part of the quote. It doesn't, however, work if you're quoting from nodes/first posts in the forum as the signature seems to get hard-coded into the node.

I haven't made this into a patch, and there is probably a better way of achieving the same result but this was the quickest and easiest solution I could find! hope it helps some of you.

triss’s picture

triss commented

I don't remember exactly how I got it to work, but I now use a combination of signature and flatforum (signatures are only used in the forum, and flatforum contains some logic to handle signatures as well). I don't know why i had to leave signatures enabled, but for some reason i could not remove the module after having used it because of some problem I do not remember. I just enabled signature for a node-type that is not in use on the site, so that keeps the signature functionality i needed (because of the problem i don't recall), withouyt it messing with the quote module... Sorry to be so vague, but I really don't remember why I did it this way, and I'm hesitant to mess with it again now that it's working...

mightyiam’s picture

mightyiam commented

Would make much use of this module and waiting on this bug. Good work.

Zen’s picture

Zen commented

I haven't tested this, but you can try playing with module weights and try to set the quote module a weight heavier than the signature module. I believe there is a module that will do this for you or alternatively, you can try doing this yourself via the system table in your database.

dmetzcher’s picture

dmetzcher commented

Thanks a lot for posting this. It does enough to make things work a lot better when quoting. :)

Zen’s picture

Zen commented
Status: Active » Fixed
Anonymous’s picture

(not verified) commented
Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.