For the URL notifications/subscription/%notifications_subscription/edit, there is a "Delete subscription" button that does nothing when pressed, even for user1.
Is this button needed since there is a delete tab?
For the URL notifications/subscription/%notifications_subscription, there is a "Cancel" button that does nothing when pressed, even for user1.
This is not needed since that page is basically a "view" page, not any sort of "edit" page.
| Comment | File | Size | Author |
|---|---|---|---|
| #2 | cancel-and-delete-button-1307594-2.patch | 2.56 KB | webflo |
| #1 | 0001-fixed-extra-buttons-delete-and-cancel.patch | 1.78 KB | that0n3guy |
| #1 | 0001-removed-extra-buttons.patch | 1.71 KB | that0n3guy |
Comments
Comment #1
that0n3guy commentedFor the extra "cancel button"
I fixed that and also made the items on that page non-selectable since they are select lists without a submit button. Both of the patches below fix that.
For the "delete button"
There are 2 ways to fix this:
* One is to fix the delete button so it works. The patch called "0001-fixed-extra-buttons-delete-and-cancel" does this.
* Second is to just remove the delete button from the page since there is a delete tab... we don't need both. This is probably the patch I would think we will go with. The patch called '0001-removed-extra-buttons' does this.
NOTE: don't apply both patches... its either one or the other.
Comment #2
webflo commentedLets use triggering element for that. Its more robust if someone want to change the button text (button value). I think the "Delete" button is ok.
Comment #3
webflo commentedCommit 58505f0 on 7.x-1.x.