Closed (fixed)
Project:
Metatag
Version:
7.x-1.x-dev
Component:
Open Graph
Priority:
Major
Category:
Feature request
Assigned:
Unassigned
Reporter:
Created:
12 Oct 2011 at 20:17 UTC
Updated:
4 Aug 2021 at 09:37 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
dnotes commentedI saw that in the metatag_opengraph module, this is foreshadowed by a reference to select_or_other module. I'm thinking that another dependency might not be warranted. I see three options for this:
1. use autocorrect instead of a select list, and provide a link to the facebook documentation, with the predicate that most people modifying the opengraph type should be familiar enough with what that means to use the correct options without being constrained by a select
2. allow administrators to define custom opengraph types on an administration page specifically for the metatag_opengraph module
3. just write a one-off ui for this page
I'd be okay with any of the above, but like I say I'd rather not have another dependency to get this functionality, which could become increasingly common with the new beta of opengraph.
Comment #2
dave reidI've debated making the og:type a vocabulary with terms for each type and installing the vocabulary when the module is installed. That way the admin can add new Open Graph types using the taxonomy UI.
There wouldn't be a hard dependency on select_or_other, it would be optional support if the module is installed.
Comment #3
Anonymous (not verified) commentedI suggest a simple textfield. You can add a list/help for official types below it. People can read.
Comment #4
beatnbite commentedI believe a simple textfield with a link to http://ogp.me/#types will be enough.
Comment #5
nilsja commentedis there a solution for adding a custom og:type already?
Comment #6
nilsja commentedor did you figure out how to patch the module to offer the custom type in the type dropdown?
Comment #7
B Leg commentedHas this been solved/implemented yet? It's essentially a requirement for the usefulness of the module.
Comment #8
generalconsensus commentedThis is definitely a must
Comment #9
damienmckennaFrom a POV of simplicity, select_or_other would be the best option right now, defaulting to a simple selector if select_or_other is not installed. Any site with more advanced needs can modify it further with the hooks, but this module should be simple and "just work".
Comment #10
juampynr commentedHere is a patch that adds light integration with select_or_othermodule when it is available.
Comment #11
damienmckennaNice idea, it'd be worth adding a note to the README.txt about it too.
Comment #12
juampynr commentedSure, here it is.
Comment #13
damienmckennaNice! Tested & committed!
Comment #15
damienmckenna