Comments

dnotes’s picture

I saw that in the metatag_opengraph module, this is foreshadowed by a reference to select_or_other module. I'm thinking that another dependency might not be warranted. I see three options for this:

1. use autocorrect instead of a select list, and provide a link to the facebook documentation, with the predicate that most people modifying the opengraph type should be familiar enough with what that means to use the correct options without being constrained by a select
2. allow administrators to define custom opengraph types on an administration page specifically for the metatag_opengraph module
3. just write a one-off ui for this page

I'd be okay with any of the above, but like I say I'd rather not have another dependency to get this functionality, which could become increasingly common with the new beta of opengraph.

dave reid’s picture

Version: 7.x-1.0-alpha3 »
Component: Code » Open Graph

I've debated making the og:type a vocabulary with terms for each type and installing the vocabulary when the module is installed. That way the admin can add new Open Graph types using the taxonomy UI.

There wouldn't be a hard dependency on select_or_other, it would be optional support if the module is installed.

Anonymous’s picture

Version: » 7.x-1.x-dev

I suggest a simple textfield. You can add a list/help for official types below it. People can read.

beatnbite’s picture

I believe a simple textfield with a link to http://ogp.me/#types will be enough.

nilsja’s picture

is there a solution for adding a custom og:type already?

nilsja’s picture

or did you figure out how to patch the module to offer the custom type in the type dropdown?

B Leg’s picture

Has this been solved/implemented yet? It's essentially a requirement for the usefulness of the module.

generalconsensus’s picture

This is definitely a must

damienmckenna’s picture

Assigned: Unassigned » damienmckenna

From a POV of simplicity, select_or_other would be the best option right now, defaulting to a simple selector if select_or_other is not installed. Any site with more advanced needs can modify it further with the hooks, but this module should be simple and "just work".

juampynr’s picture

Status: Active » Needs review
StatusFileSize
new1.54 KB

Here is a patch that adds light integration with select_or_othermodule when it is available.

damienmckenna’s picture

Status: Needs review » Needs work

Nice idea, it'd be worth adding a note to the README.txt about it too.

juampynr’s picture

Title: Please add option for custom og:type » Support custom Open Graph types
Status: Needs work » Needs review
StatusFileSize
new2.44 KB

Sure, here it is.

damienmckenna’s picture

Status: Needs review » Fixed

Nice! Tested & committed!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

damienmckenna’s picture

Assigned: damienmckenna » Unassigned
Issue summary: View changes