Closed (fixed)
Project:
Rubik
Version:
7.x-4.x-dev
Component:
Code
Priority:
Major
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
12 Oct 2011 at 20:39 UTC
Updated:
2 Sep 2013 at 07:41 UTC
Jump to comment: Most recent file
After installing the metatag module, was not able to access the ":Advanced" fieldset (collapsed) as the legend for that fieldset had a style of display:none. Not sure what other modules, interfaces, etc. this might affect.
| Comment | File | Size | Author |
|---|---|---|---|
| #8 | rubik-fieldset-in-fieldset-display-1307826-5.patch | 578 bytes | acbramley |
| #8 | post-new-patch.png | 157.28 KB | acbramley |
| #5 | fieldsets-pre-patch.png | 126.51 KB | acbramley |
| #5 | post-patch.png | 196.08 KB | acbramley |
| #4 | rubik-fieldset-in-fieldset-display-1307826-4.patch | 428 bytes | wbobeirne |
Comments
Comment #1
ben.hamelinClosing this, addressed in this issue:
http://drupal.org/node/1307806
Comment #2
realityloop commentedActually it's not fully addresssed, I needed to add the following to rubik's core.css to resolve it
Comment #3
realityloop commentedpatch is against beta8
Comment #4
wbobeirne commentedI don't think #2 is what we want, since that will show the legends at the top of vertical tabs, which is the original reason that rule exists. Attached is a patch that will show the legends of other fieldsets inside of a vertical tab, but not the legend at the top. Also, upping this issue to major as it inhibits functionality of other modules, such as metatags as mentioned above, and scheduler on pre 7.14 versions of drupal.
Comment #5
acbramley commented@wbobeirne thank you so much, #4 fixed an issue I was having which stopped me editing half the behaviour settings available to an Openlayers map when using Rubik. I there still needs to be some extra work though, here's my pre patch and post patch screenshots with some annotations to show my issues. The un-collapsing is also adding some padding which makes the fieldset appear to drop down 5 or so pixels when you open it up
Comment #6
acbramley commentedAlso, is this a duplicate of #986566: Nested fieldsets not appearing
Comment #7
acbramley commentedChanging title
Comment #8
acbramley commentedHave added some to the patch as the very generic line 233 of core.css removes all borders and margins from the collapsible fieldsets. This patch adds a border round them. Testing with the openlayers behaviours page as per #5 and it looks much better now. Not sure if this will impact much on anything else in the theme, but it seems reasonable to me (however I'm not generally a themer).
The screenshot attached shows the new display with this patch, notice the improvement from the previous screenshots in #5
Comment #9
acbramley commentedThe above patch also fixes the issue I noted in #5 with the awkward user interaction of not being able to click the text.
Comment #10
wiifm+1, lets get this simple patch in. Currently fieldsets within vertical tabs are a mess on Rubik. This patch goes a long way to making them usable.
Comment #11
haydeniv commentedCommitted: 76fbd45
Thanks!