twitter_post implemented hook_nodeapi, which is not used in drupal 7 anymore. The attached patch fixes this by using hook_node_insert() and hook_node_update().

CommentFileSizeAuthor
#10 twitter_post_fix-1307862-10.patch965 bytesplopesc
#3 twitter_post_improvements-1307862-3.patch1.23 KBplopesc
#1 twitter_post_drupal_7_fix-v2.patch3.33 KBgnoddep
twitter_post_drupal_7_fix.patch3.33 KBgnoddep

Comments

gnoddep’s picture

gnoddep commented
StatusFileSize
new twitter_post_drupal_7_fix-v2.patch3.33 KB

Fixed the patch, it should apply with git --apply now

juampynr’s picture

juampynr commented
Status: Needs review » Fixed

Verified and committed:

http://drupalcode.org/project/twitter.git/commit/1960e16ca806b3b19321790...
http://drupalcode.org/project/twitter.git/commit/57fe857d2e12b5440624a43...

Thanks!

plopesc’s picture

plopesc
he/him
Primary language Spanish
commented
StatusFileSize
new twitter_post_improvements-1307862-3.patch1.23 KB

Hello

I made some minor improvements in the patch provided by gnodepp:

  • Twitter Post fieldset is included in the "Aditional Settings" vertical tabs component
  • It works with hook_node_presave instead of hook_node_insert and hook_node_update

Regards

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

juampynr’s picture

juampynr commented
Category: bug » feature
Priority: Major » Normal
Status: Closed (fixed) » Needs review

Updated status to evaluate it when we get to a lower number of bug issues.

@plopesc, wont you participate in the #DrupalConTribute Twitter? Check out the Madrid group.

Alex Andrascu’s picture

Alex Andrascu commented

Is this going to get at least in .dev at some point before D8 is out ?

juampynr’s picture

juampynr commented
Status: Needs review » Fixed

Committed. Many thanks.

http://drupalcode.org/project/twitter.git/commitdiff/b13f4be

chia’s picture

chia commented
Status: Fixed » Needs work

I think its better to use hook_node_insert and hook_node_update.

During a new node creating, we dont have the node url in hook_node_presave (because we dont have nid) at that time.

juampynr’s picture

juampynr commented

@plopesc, can you revert back that bit and keep the grouping in a new patch?

plopesc’s picture

plopesc
he/him
Primary language Spanish
commented
Status: Fixed » Needs review
StatusFileSize
new twitter_post_fix-1307862-10.patch965 bytes

You are right, chia

I rerrolled the patch fixing that problem.

I'm going to create a test file for this module later.

Regards

juampynr’s picture

juampynr commented
Status: Needs work » Fixed

Committed. Many thanks.

http://drupalcode.org/project/twitter.git/commitdiff/d7d160f

Status: Needs review » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.